From 4adea7a7f775206d5009de03ba6172aac9ea9ee6 Mon Sep 17 00:00:00 2001 From: topepo Date: Sun, 16 Nov 2025 11:48:13 -0500 Subject: [PATCH 1/6] catboost parameter updates --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index d58484e..91bb958 100644 --- a/.gitignore +++ b/.gitignore @@ -11,3 +11,4 @@ revdep/library.noindex revdep/data.sqlite .httr-oauth revdep/cloud.noindex/* +train_dir/ \ No newline at end of file From 2ac974325404c7685ed27c62585446be35b16793 Mon Sep 17 00:00:00 2001 From: topepo Date: Sun, 16 Nov 2025 11:50:39 -0500 Subject: [PATCH 2/6] catboost parameter updates --- .Rbuildignore | 3 ++- DESCRIPTION | 2 +- R/catboost_data.R | 29 ++++++++++++++++++++++++++++- man/bonsai-package.Rd | 2 +- 4 files changed, 32 insertions(+), 4 deletions(-) diff --git a/.Rbuildignore b/.Rbuildignore index 203884b..3884fb3 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -12,4 +12,5 @@ inst/figs/ ^README\.Rmd$ ^[\.]?air\.toml$ ^\.vscode$ -^revdep$ \ No newline at end of file +^revdep$ +^train_dir$ diff --git a/DESCRIPTION b/DESCRIPTION index ad01d66..7b7e7c8 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -57,4 +57,4 @@ Config/testthat/edition: 3 Config/usethis/last-upkeep: 2025-04-25 Encoding: UTF-8 Roxygen: list(markdown = TRUE) -RoxygenNote: 7.3.2 +RoxygenNote: 7.3.3 diff --git a/R/catboost_data.R b/R/catboost_data.R index 7c87e2b..6d77281 100644 --- a/R/catboost_data.R +++ b/R/catboost_data.R @@ -184,11 +184,38 @@ make_boost_tree_catboost <- function() { parsnip::set_model_arg( model = "boost_tree", eng = "catboost", - parsnip = "mtry_prop", + parsnip = "mtry", original = "rsm", func = list(pkg = "dials", fun = "mtry_prop"), has_submodel = FALSE ) + + parsnip::set_model_arg( + model = "boost_tree", + eng = "catboost", + parsnip = "min_n", + original = "min_data_in_leaf", + func = list(pkg = "dials", fun = "min_n"), + has_submodel = FALSE + ) + + parsnip::set_model_arg( + model = "boost_tree", + eng = "catboost", + parsnip = "sample_size", + original = "subsample", + func = list(pkg = "dials", fun = "sample_prop"), + has_submodel = FALSE + ) + + parsnip::set_model_arg( + model = "boost_tree", + eng = "catboost", + parsnip = "stop_iter", + original = "early_stopping_rounds", + func = list(pkg = "dials", fun = "stop_iter"), + has_submodel = FALSE + ) } # nocov end diff --git a/man/bonsai-package.Rd b/man/bonsai-package.Rd index f6a21f1..496b9fd 100644 --- a/man/bonsai-package.Rd +++ b/man/bonsai-package.Rd @@ -33,7 +33,7 @@ Authors: Other contributors: \itemize{ - \item Posit Software, PBC (03wc8by49) [copyright holder, funder] + \item Posit Software, PBC (\href{https://ror.org/03wc8by49}{ROR}) [copyright holder, funder] } } From a931d506d307604e71042057850d90dd38e286b6 Mon Sep 17 00:00:00 2001 From: topepo Date: Sun, 16 Nov 2025 12:27:14 -0500 Subject: [PATCH 3/6] coincidental PR for parsnip tidymodels/parsnip#1306 --- DESCRIPTION | 2 ++ 1 file changed, 2 insertions(+) diff --git a/DESCRIPTION b/DESCRIPTION index 7b7e7c8..e68109a 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -50,6 +50,8 @@ Suggests: rsample, testthat (>= 3.0.0), tune +Remotes: + parsnip (>= 1.3.3.9000), VignetteBuilder: knitr Config/Needs/website: tidyverse/tidytemplate From 0e35290757bcc35e30505939d712779d87fe6aeb Mon Sep 17 00:00:00 2001 From: topepo Date: Sun, 16 Nov 2025 12:27:26 -0500 Subject: [PATCH 4/6] news --- NEWS.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/NEWS.md b/NEWS.md index 3cf46dd..346d39a 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,9 @@ # bonsai (development version) +* catboost tuning parameters were updates: + - Fixed a bug in `mtry`; it used the parsnip name `mtry_prop`. + - Enabled model arguments for `min_n`, `sample_size`, and `stop_iter`. `min_n` is only enabled for GPU computations. + # bonsai 0.4.0 ## New Engines From 0eac881dd113a6d984e59b184fa71e00bace2872 Mon Sep 17 00:00:00 2001 From: topepo Date: Sun, 16 Nov 2025 12:39:52 -0500 Subject: [PATCH 5/6] fix remote --- DESCRIPTION | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index e68109a..87e25f4 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -26,7 +26,7 @@ License: MIT + file LICENSE URL: https://bonsai.tidymodels.org/, https://github.com/tidymodels/bonsai BugReports: https://github.com/tidymodels/bonsai/issues Depends: - parsnip (>= 1.0.1), + parsnip (>= 1.3.3.9000), R (>= 4.1) Imports: cli, @@ -50,10 +50,10 @@ Suggests: rsample, testthat (>= 3.0.0), tune -Remotes: - parsnip (>= 1.3.3.9000), VignetteBuilder: knitr +Remotes: + tidymodels/parsnip Config/Needs/website: tidyverse/tidytemplate Config/testthat/edition: 3 Config/usethis/last-upkeep: 2025-04-25 From 324feaaca3ca3bbf00feaf22f03160c4edd069f0 Mon Sep 17 00:00:00 2001 From: Emil Hvitfeldt Date: Wed, 19 Nov 2025 08:01:16 -0800 Subject: [PATCH 6/6] Update NEWS.md --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 346d39a..cafc0f3 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,6 @@ # bonsai (development version) -* catboost tuning parameters were updates: +* catboost tuning parameters were updates: (#119) - Fixed a bug in `mtry`; it used the parsnip name `mtry_prop`. - Enabled model arguments for `min_n`, `sample_size`, and `stop_iter`. `min_n` is only enabled for GPU computations.