Skip to content

Commit 478a52c

Browse files
topepo‘topepo’
andauthored
Updates for brulee_mlp_two_layer (#84)
* new function for two layer models * two layer unit tests * avoid overflow issues * fix doc error * test when loss cannot be computed * tests for tunable values * update GHA * update spelling * use current CRAN torch * add missing snapshot and remove print snapshots (due to OS differences) * don't test on R 4.1 * test overflow on M1 mac * small update * finalize tunable for 2layer networks * finalize tunable for 2layer networks * remove tunable info (moved to parsnip) * remove test file --------- Co-authored-by: ‘topepo’ <‘[email protected]’>
1 parent 0f90be5 commit 478a52c

File tree

7 files changed

+5
-162
lines changed

7 files changed

+5
-162
lines changed

.github/workflows/test-coverage.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ name: test-coverage.yaml
1010

1111
permissions: read-all
1212

13+
permissions: read-all
14+
1315
jobs:
1416
test-coverage:
1517
runs-on: ubuntu-latest

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,4 @@ Config/testthat/edition: 3
4040
Encoding: UTF-8
4141
Language: en-US
4242
Roxygen: list(markdown = TRUE)
43-
RoxygenNote: 7.3.1
43+
RoxygenNote: 7.3.2

NAMESPACE

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,6 @@ S3method(print,brulee_linear_reg)
4141
S3method(print,brulee_logistic_reg)
4242
S3method(print,brulee_mlp)
4343
S3method(print,brulee_multinomial_reg)
44-
S3method(tunable,brulee_linear_reg)
45-
S3method(tunable,brulee_logistic_reg)
46-
S3method(tunable,brulee_mlp)
47-
S3method(tunable,brulee_mlp_two_layer)
48-
S3method(tunable,brulee_multinomial_reg)
4944
export("%>%")
5045
export(autoplot)
5146
export(brulee_activations)

R/tunable.R

Lines changed: 0 additions & 121 deletions
This file was deleted.

man/brulee-internal.Rd

Lines changed: 0 additions & 25 deletions
This file was deleted.

tests/testthat/_snaps/tunable.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@
336336
[1] "dials"
337337
338338
[[3]]$fun
339-
[1] "hidden_units"
339+
[1] "hidden_units_2"
340340
341341
[[3]]$range
342342
[1] 2 50
@@ -358,7 +358,7 @@
358358
[1] "dials"
359359
360360
[[5]]$fun
361-
[1] "activation"
361+
[1] "activation_2"
362362
363363
[[5]]$values
364364
[1] "relu" "tanh" "elu" "log_sigmoid" "tanhshrink"

tests/testthat/test-tunable.R

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)