Skip to content

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Jan 28, 2025

closes #1215, as a pair with tidymodels/hardhat#278

@hfrick
Copy link
Member Author

hfrick commented Jan 28, 2025

That failed check is one on the parsnip overhead but since that test passes on all other platforms, I think it's not related to this change.

@hfrick hfrick requested a review from topepo January 28, 2025 18:03
Copy link
Member

@topepo topepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I ran revdeps and there was a good test case in the LorenzRegression package (using parsnip::contr_one_hot())

@topepo
Copy link
Member

topepo commented Jan 29, 2025

Although I do see an additional warning for

Found the following significant warnings:
Warning: replacing previous import ‘hardhat::contr_one_hot’ by
‘parsnip::contr_one_hot’ when loading ‘viralmodels’

I'll add an issues to their repo.

@topepo topepo merged commit 8adb5cc into main Jan 29, 2025
10 checks passed
@topepo topepo deleted the consolidate-contr_one_hot branch January 29, 2025 16:49
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

contr_one_hot() is also in hardhat but not exported

2 participants