From a7327c96e626a06363177453e6419563bec5e077 Mon Sep 17 00:00:00 2001 From: Bjorn Kallerud Date: Fri, 19 Sep 2025 12:07:57 -0700 Subject: [PATCH 1/2] Make surv_reg() defunct and update NEWS --- NEWS.md | 2 ++ R/surv_reg.R | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index be6c445f2..e900874cb 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,7 @@ # parsnip (development version) +* `surv_reg()` is now defunct and will error if called. Please use `survival_reg()` instead (#1206). + # parsnip 1.3.3 * Bug fix in how tunable parameters were configured for brulee neural networks. diff --git a/R/surv_reg.R b/R/surv_reg.R index a515e42d1..7ad003500 100644 --- a/R/surv_reg.R +++ b/R/surv_reg.R @@ -28,7 +28,7 @@ #' @export surv_reg <- function(mode = "regression", engine = "survival", dist = NULL) { - lifecycle::deprecate_warn("0.1.6", "surv_reg()", "survival_reg()") + lifecycle::deprecate_stop("1.4.0", "surv_reg()", "survival_reg()") args <- list( dist = enquo(dist) From 8928da48ea5d0454b7fd5b59c19e3a3f3050b95f Mon Sep 17 00:00:00 2001 From: Max Kuhn Date: Fri, 19 Sep 2025 15:35:32 -0400 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- R/surv_reg.R | 1 - 1 file changed, 1 deletion(-) diff --git a/R/surv_reg.R b/R/surv_reg.R index 7ad003500..94f4836ec 100644 --- a/R/surv_reg.R +++ b/R/surv_reg.R @@ -27,7 +27,6 @@ #' @keywords internal #' @export surv_reg <- function(mode = "regression", engine = "survival", dist = NULL) { - lifecycle::deprecate_stop("1.4.0", "surv_reg()", "survival_reg()") args <- list(