Skip to content

Commit 0697f47

Browse files
authored
lower bound of a parameter range now can't exceed the upper bound (#1129)
1 parent fc5711b commit 0697f47

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

tests/testthat/_snaps/tune_bayes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@
443443
res_fail <- tune_bayes(mod, Sale_Price ~ Neighborhood + Gr_Liv_Area +
444444
Year_Built + Bldg_Type + Latitude + Longitude, resamples = folds, initial = 5,
445445
metrics = yardstick::metric_set(rsq), param_info = parameters(dials::cost_complexity(
446-
c(0.5, 0))))
446+
c(0, 0.5))))
447447
Message
448448
> A | warning: A correlation computation is required, but `estimate` is constant and has 0 standard deviation, resulting in a divide by 0 error. `NA` will be returned.
449449
! All of the rsq estimates were missing. The Gaussian process model cannot be

tests/testthat/test-tune_bayes.R

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -564,11 +564,11 @@ test_that("missing performance values", {
564564
tune_bayes(
565565
Sale_Price ~
566566
Neighborhood +
567-
Gr_Liv_Area +
568-
Year_Built +
569-
Bldg_Type +
570-
Latitude +
571-
Longitude,
567+
Gr_Liv_Area +
568+
Year_Built +
569+
Bldg_Type +
570+
Latitude +
571+
Longitude,
572572
resamples = folds,
573573
initial = 3,
574574
metrics = yardstick::metric_set(rsq),
@@ -583,15 +583,15 @@ test_that("missing performance values", {
583583
tune_bayes(
584584
Sale_Price ~
585585
Neighborhood +
586-
Gr_Liv_Area +
587-
Year_Built +
588-
Bldg_Type +
589-
Latitude +
590-
Longitude,
586+
Gr_Liv_Area +
587+
Year_Built +
588+
Bldg_Type +
589+
Latitude +
590+
Longitude,
591591
resamples = folds,
592592
initial = 5,
593593
metrics = yardstick::metric_set(rsq),
594-
param_info = parameters(dials::cost_complexity(c(0.5, 0)))
594+
param_info = parameters(dials::cost_complexity(c(0, 0.5)))
595595
)
596596
})
597597
})

0 commit comments

Comments
 (0)