Dead exported function: `finalize_workflow_preprocessor()`

[hfrick]

Summary

finalize_workflow_preprocessor() is exported (via @rdname tune-internal-functions) but has zero callers in R/, tests/, or inst/.

Location

tune/R/grid_helpers.R

Lines 115 to 129 in 3544816

	#' @export
	#' @rdname tune-internal-functions
	finalize_workflow_preprocessor <- function(workflow, grid_preprocessor) {
	# Already finalized, nothing to tune
	if (ncol(grid_preprocessor) == 0L) {
	return(workflow)
	}
	recipe <- extract_preprocessor(workflow)
	recipe <- merge(recipe, grid_preprocessor)$x[[1]]
	workflow <- set_workflow_recipe(workflow, recipe)
	workflow
	}

What it does

Finalizes a workflow's recipe preprocessor by merging tuning parameter values from a grid into the recipe. If the grid has no columns, it returns the workflow unchanged.

Why it's dead

The current loop architecture uses finalize_fit_pre() (in R/loop_over_all_stages-helpers.R) instead, which handles preprocessor finalization as part of the broader fit pipeline.

Suggested fix

Check whether any downstream packages (e.g., finetune, workflowsets) call this function. If not, deprecate it.

[hfrick]

This is used in tidyclust and agua, but not finetune or workflowsets:
https://github.com/search?q=org%3Atidymodels%20finalize_workflow_preprocessor&type=code

tidyclust

https://github.com/tidymodels/tidyclust/blob/1b045f3e1f8726ef453c430330e1a780b5be8fbd/R/tune_cluster.R#L438-L441

This would (most likely) be removed when we integrate tidyclust into tune: tidymodels/tidyclust#220
https://github.com/tidymodels/tidyclust/pull/220/changes#diff-1279eea45020f3558f8ae4eea8e95626de009f31b2da9bd36bfc9806a33e82adL438

auga

https://github.com/tidymodels/agua/blob/dfc7a13ad37d5ddbe58cb4d37f6b4de494118a20/R/tune.R#L101-L104

Also agua has some major changes pending which may be an opportunity to stop using finalize_workflow_preprocessor():
tidymodels/agua#59

So let's deprecate this, starting with deprecate_warn().