Skip to content

Commit 1ee49e2

Browse files
committed
Vertical legend lines for pointrange and linerange.
1 parent 39274b4 commit 1ee49e2

File tree

5 files changed

+23
-2
lines changed

5 files changed

+23
-2
lines changed

NAMESPACE

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,7 @@ export(draw_key_rect)
247247
export(draw_key_smooth)
248248
export(draw_key_text)
249249
export(draw_key_vline)
250+
export(draw_key_vpath)
250251
export(element_blank)
251252
export(element_grob)
252253
export(element_line)

NEWS.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,9 @@ All defunct functions have been removed.
164164
border has been tweaked to be more visible, and more closely match the size of
165165
line drawn on the plot.
166166

167+
* `geom_pointrange()` and `geom_linerange()` get vertical (not horizontal)
168+
lines in the legend (#1389).
169+
167170
* The default line `size` for `geom_smooth()` has been increased from 0.5 to 1
168171
to make it easier to see when overlaid on data.
169172

R/geom-linerange.r

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ geom_linerange <- function(mapping = NULL, data = NULL, stat = "identity",
7373
GeomLinerange <- ggproto("GeomLinerange", Geom,
7474
default_aes = aes(colour = "black", size = 0.5, linetype = 1, alpha = NA),
7575

76-
draw_key = draw_key_path,
76+
draw_key = draw_key_vpath,
7777

7878
required_aes = c("x", "ymin", "ymax"),
7979

R/legend-draw.r

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,20 @@ draw_key_path <- function(data, params, size) {
117117
)
118118
}
119119

120+
#' @export
121+
#' @rdname draw_key
122+
draw_key_vpath <- function(data, params, size) {
123+
segmentsGrob(0.5, 0.1, 0.5, 0.9,
124+
gp = gpar(
125+
col = alpha(data$colour, data$alpha),
126+
lwd = data$size * .pt,
127+
lty = data$linetype,
128+
lineend = "butt"
129+
),
130+
arrow = params$arrow
131+
)
132+
}
133+
120134
#' @export
121135
#' @rdname draw_key
122136
draw_key_dotplot <- function(data, params, size) {
@@ -133,7 +147,7 @@ draw_key_dotplot <- function(data, params, size) {
133147
#' @rdname draw_key
134148
draw_key_pointrange <- function(data, params, size) {
135149
grobTree(
136-
draw_key_path(data, params),
150+
draw_key_vpath(data, params, size),
137151
draw_key_point(transform(data, size = data$size * 4), params)
138152
)
139153
}

man/draw_key.Rd

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)