Skip to content

Commit 6138cf2

Browse files
committed
consistently use is_theme_element()
1 parent 9428029 commit 6138cf2

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

R/coord-sf.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ CoordSf <- ggproto("CoordSf", CoordCartesian,
334334

335335
# we don't draw the graticules if the major panel grid is
336336
# turned off
337-
if (inherits(el, "element_blank")) {
337+
if (is_theme_element(el, "blank")) {
338338
grobs <- list(element_render(theme, "panel.background"))
339339
} else {
340340
line_gp <- gg_par(

R/guide-axis-theta.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ GuideAxisTheta <- ggproto(
184184

185185
build_labels = function(key, elements, params) {
186186

187-
if (inherits(elements$text, "element_blank")) {
187+
if (is_theme_element(elements$text, "blank")) {
188188
return(zeroGrob())
189189
}
190190

@@ -268,7 +268,7 @@ GuideAxisTheta <- ggproto(
268268
key <- params$key
269269
key <- vec_slice(key, !is.na(key$.label) & nzchar(key$.label))
270270
labels <- validate_labels(key$.label)
271-
if (length(labels) == 0 || inherits(elements$text, "element_blank")) {
271+
if (length(labels) == 0 || is_theme_element(elements$text, "blank")) {
272272
return(list(offset = offset))
273273
}
274274

@@ -365,7 +365,7 @@ GuideAxisTheta <- ggproto(
365365

366366
theta_tickmarks <- function(key, element, length, offset = NULL) {
367367
n_breaks <- nrow(key)
368-
if (n_breaks < 1 || inherits(element, "element_blank")) {
368+
if (n_breaks < 1 || is_theme_element(element, "blank")) {
369369
return(zeroGrob())
370370
}
371371

R/guide-axis.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,10 +259,10 @@ GuideAxis <- ggproto(
259259
override_elements = function(params, elements, theme) {
260260
elements$text <-
261261
label_angle_heuristic(elements$text, params$position, params$angle)
262-
if (inherits(elements$ticks, "element_blank")) {
262+
if (is_theme_element(elements$ticks, "blank")) {
263263
elements$major_length <- unit(0, "cm")
264264
}
265-
if (inherits(elements$minor, "element_blank") || isFALSE(params$minor.ticks)) {
265+
if (is_theme_element(elements$minor, "blank") || isFALSE(params$minor.ticks)) {
266266
elements$minor_length <- unit(0, "cm")
267267
}
268268
return(elements)
@@ -379,7 +379,7 @@ GuideAxis <- ggproto(
379379
# Ticks
380380
major_cm <- convertUnit(elements$major_length, "cm", valueOnly = TRUE)
381381
range <- range(0, major_cm)
382-
if (params$minor.ticks && !inherits(elements$minor, "element_blank")) {
382+
if (params$minor.ticks && !is_theme_element(elements$minor, "blank")) {
383383
minor_cm <- convertUnit(elements$minor_length, "cm", valueOnly = TRUE)
384384
range <- range(range, minor_cm)
385385
}
@@ -590,7 +590,7 @@ axis_label_priority_between <- function(x, y) {
590590
#' overridden from the user- or theme-supplied element.
591591
#' @noRd
592592
label_angle_heuristic <- function(element, position, angle) {
593-
if (!inherits(element, "element_text")
593+
if (!is_theme_element(element, "text")
594594
|| is.null(position)
595595
|| is.null(angle %|W|% NULL)) {
596596
return(element)

R/plot-build.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ table_add_tag <- function(table, label, theme) {
348348
return(table)
349349
}
350350
element <- calc_element("plot.tag", theme)
351-
if (inherits(element, "element_blank")) {
351+
if (is_theme_element(element, "blank")) {
352352
return(table)
353353
}
354354

R/theme-elements.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -847,7 +847,7 @@ check_element <- function(el, elname, element_tree, call = caller_env()) {
847847
if ("margin" %in% eldef$class) {
848848
if (!is.unit(el) && length(el) == 4)
849849
cli::cli_abort("The {.var {elname}} theme element must be a {.cls unit} vector of length 4.", call = call)
850-
} else if (!inherits(el, eldef$class) && !inherits(el, "element_blank")) {
850+
} else if (!inherits(el, eldef$class) && !is_theme_element(el, "blank")) {
851851
cli::cli_abort("The {.var {elname}} theme element must be a {.cls {eldef$class}} object.", call = call)
852852
}
853853
invisible()

0 commit comments

Comments
 (0)