Make scale_shape_identity use ScaleContinuousIdentity (#3075)

malcolmbarrett · karawoo · commit 652a43189388 · 2019-01-19T12:13:59.000-06:00
* fix typo in scale_fill_idenity

* update news

* move to top of news

* switch to issue number instead of PR

* fix scale_shape_identity news item
diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,6 @@
 # ggplot2 3.1.0.9000
+  
+* `scale_shape_identity()` now works correctly with `guide = "legend"` (@malcolmbarrett, #3029)
 
 * Facet strips on the left side of plots now have clipping turned on, preventing
   text from running out of the strip and borders from looking thicker than for
diff --git a/R/scale-identity.r b/R/scale-identity.r
@@ -81,7 +81,7 @@ scale_fill_identity <- function(..., guide = "none", aesthetics = "fill") {
 #' @export
 scale_shape_identity <- function(..., guide = "none") {
   sc <- continuous_scale("shape", "identity", identity_pal(), ..., guide = guide,
-    super = ScaleDiscreteIdentity)
+    super = ScaleContinuousIdentity)
 
   sc
 }

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ scale_fill_identity <- function(..., guide = "none", aesthetics = "fill") {`
`81`	`81`	`#' @export`
`82`	`82`	`scale_shape_identity <- function(..., guide = "none") {`
`83`	`83`	`sc <- continuous_scale("shape", "identity", identity_pal(), ..., guide = guide,`
`84`		`- super = ScaleDiscreteIdentity)`
	`84`	`+ super = ScaleContinuousIdentity)`
`85`	`85`
`86`	`86`	`sc`
`87`	`87`	`}`