Skip to content

Commit 7251f11

Browse files
committed
simplify fallback_palette() args
1 parent 00dd12c commit 7251f11

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

R/scale-.R

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -526,9 +526,7 @@ Scale <- ggproto("Scale", NULL,
526526
if (empty(df)) {
527527
return()
528528
}
529-
if (is.null(self$palette)) {
530-
self$palette <- fallback_palette(self$aesthetics[1], self$is_discrete())
531-
}
529+
self$palette <- self$palette %||% fallback_palette(self)
532530

533531
aesthetics <- intersect(self$aesthetics, names(df))
534532
names(aesthetics) <- aesthetics

R/scales-.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ ScalesList <- ggproto("ScalesList", NULL,
199199
}
200200
}
201201

202-
elem <- elem %||% fallback_palette(scale$aesthetics[1], scale$is_discrete())
202+
elem <- elem %||% fallback_palette(scale)
203203

204204
if (!is.function(elem)) {
205205
cli::cli_warn(

R/utilities.R

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -777,7 +777,9 @@ as_unordered_factor <- function(x) {
777777
x
778778
}
779779

780-
fallback_palette <- function(aes, discrete) {
780+
fallback_palette <- function(scale) {
781+
aes <- scale$aesthetics[1]
782+
discrete <- scale$is_discrete()
781783
if (discrete) {
782784
pal <- switch(
783785
aes,

0 commit comments

Comments
 (0)