Skip to content

Commit 84e7f34

Browse files
committed
avoid rel(0) margins, fix #6536
1 parent afc2360 commit 84e7f34

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

R/theme-defaults.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ theme_grey <- function(base_size = 11, base_family = "",
220220
legend.direction = NULL,
221221
legend.justification = "center",
222222
legend.box = NULL,
223-
legend.box.margin = rel(0),
223+
legend.box.margin = margin_auto(0),
224224
legend.box.background = element_blank(),
225225
legend.box.spacing = rel(2),
226226

@@ -562,8 +562,8 @@ theme_void <- function(base_size = 11, base_family = "",
562562
legend.text = element_text(size = rel(0.8)),
563563
legend.title = element_text(hjust = 0),
564564
legend.key.spacing = rel(1),
565-
legend.margin = rel(0),
566-
legend.box.margin = rel(0),
565+
legend.margin = margin_auto(0),
566+
legend.box.margin = margin_auto(0),
567567
legend.box.spacing = unit(0.2, "cm"),
568568
legend.ticks.length = rel(0.2),
569569
legend.background = element_blank(),
@@ -578,7 +578,7 @@ theme_void <- function(base_size = 11, base_family = "",
578578
panel.spacing = NULL,
579579
panel.background = element_blank(),
580580
panel.border = element_blank(),
581-
plot.margin = rel(0),
581+
plot.margin = margin_auto(0),
582582
plot.title = element_text(
583583
size = rel(1.2),
584584
hjust = 0, vjust = 1,

R/theme.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -916,7 +916,7 @@ S7::method(merge_element, list(element, S7::class_any)) <-
916916

917917
S7::method(merge_element, list(margin, S7::class_any)) <-
918918
function(new, old, ...) {
919-
if (anyNA(new)) {
919+
if (anyNA(new) && is_margin(old)) {
920920
new[is.na(new)] <- old[is.na(new)]
921921
}
922922
new

0 commit comments

Comments
 (0)