Skip to content

Commit b91fe31

Browse files
committed
protect against arrow/arrow.fill partial match
1 parent e0b0719 commit b91fe31

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

R/legend-draw.R

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -207,11 +207,11 @@ draw_key_path <- function(data, params, size) {
207207
lty = data$linetype %||% 1,
208208
lineend = params$lineend %||% "butt"
209209
),
210-
arrow = params$arrow
210+
arrow = params[["arrow"]]
211211
)
212-
if (!is.null(params$arrow)) {
213-
angle <- deg2rad(params$arrow$angle)
214-
length <- convertUnit(params$arrow$length, "cm", valueOnly = TRUE)
212+
if (!is.null(params[["arrow"]])) {
213+
angle <- deg2rad(params[["arrow"]]$angle)
214+
length <- convertUnit(params[["arrow"]]$length, "cm", valueOnly = TRUE)
215215
attr(grob, "width") <- cos(angle) * length * 1.25
216216
attr(grob, "height") <- sin(angle) * length * 2
217217
}
@@ -228,11 +228,11 @@ draw_key_vpath <- function(data, params, size) {
228228
lty = data$linetype %||% 1,
229229
lineend = params$lineend %||% "butt"
230230
),
231-
arrow = params$arrow
231+
arrow = params[["arrow"]]
232232
)
233-
if (!is.null(params$arrow)) {
234-
angle <- deg2rad(params$arrow$angle)
235-
length <- convertUnit(params$arrow$length, "cm", valueOnly = TRUE)
233+
if (!is.null(params[["arrow"]])) {
234+
angle <- deg2rad(params[["arrow"]]$angle)
235+
length <- convertUnit(params[["arrow"]]$length, "cm", valueOnly = TRUE)
236236
attr(grob, "width") <- sin(angle) * length * 2
237237
attr(grob, "height") <- cos(angle) * length * 1.25
238238
}

R/theme-elements.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -381,10 +381,10 @@ element_grob.element_line <- function(element, x = 0:1, y = 0:1,
381381
linewidth <- size
382382
}
383383

384-
arrow <- if (is.logical(element$arrow) && !element$arrow) {
384+
arrow <- if (is.logical(element[["arrow"]]) && !element[["arrow"]]) {
385385
NULL
386386
} else {
387-
element$arrow
387+
element[["arrow"]]
388388
}
389389
if (is.null(arrow)) {
390390
arrow.fill <- colour

0 commit comments

Comments
 (0)