get rid of variant snapshots

Author: teunbrand

R/theme.R

@@ -702,7 +702,7 @@ add_theme <- function(t1, t2, t2name, call = caller_env()) {
     return(t1)
   }
   if (!is.list(t2)) { # in various places in the code base, simple lists are used as themes
-    cli::cli_abort("Can't add {.arg {t2name}} to a theme object.", call = call)
+    cli::cli_abort("Can't add {.arg {t2name}} to a theme object.", call = NULL)
   }
 
   # If t2 is a complete theme or t1 is NULL, just return t2

tests/testthat/_snaps/4.0/theme.md

@@ -1,3 +1,11 @@
+# modifying theme element properties with + operator works
+
+    Code
+      theme_grey() + "asdf"
+    Condition
+      Error:
+      ! Can't add `"asdf"` to a theme object.
+
 # theme validation happens at build stage
 
     The `text` theme element must be a <element_text> object.

tests/testthat/_snaps/4.2/theme.md

@@ -49,11 +49,7 @@ test_that("modifying theme element properties with + operator works", {
   t <- theme_grey() + theme()
   expect_identical(t, theme_grey())
 
-  expect_snapshot(
-    theme_grey() + "asdf",
-    error = TRUE,
-    variant = substr(as.character(getRversion()), start = 1, stop = 3)
-  )
+  expect_snapshot(theme_grey() + "asdf", error = TRUE)
 })
 
 test_that("adding theme object to ggplot object with + operator works", {