Skip to content

Commit f2c10f5

Browse files
committed
Refine filled point example in docs
1 parent fad53be commit f2c10f5

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

R/geom-point.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@
8585
#' ggplot(mtcars, aes(wt, mpg)) +
8686
#' geom_point(shape = 21, colour = "black", fill = "white", size = 5, stroke = 5)
8787
#'
88-
#' # The default shape used in legends is not filled, so you will need to
89-
#' # override it in the guide in order to see the fill reflected in the legend
90-
#' ggplot(mtcars, aes(wt, mpg, fill = factor(carb), shape = factor(cyl), colour = factor(vs))) +
88+
#' # The default shape in legends is not filled, but you can override the shape
89+
#' # in the guide to reflect the fill in the legend
90+
#' ggplot(mtcars, aes(wt, mpg, fill = factor(carb), shape = factor(cyl))) +
9191
#' geom_point(size = 5, stroke = 1) +
9292
#' scale_shape_manual(values = 21:25) +
9393
#' scale_fill_ordinal(guide = guide_legend(override.aes = list(shape = 21)))

man/geom_point.Rd

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vignettes/ggplot2-specs.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ ggplot(sizes, aes(size, stroke, size = size, stroke = stroke)) +
251251
scale_size_identity()
252252
```
253253

254-
Because most shapes are not filled, mapping the `fill` aesthetic of points is considered an advanced feature. Additional steps may be required to produce sensible results, such as overriding the shape used in the `fill` guide (refer to `geom_point()` for an example of this).
254+
Because points are not typically filled, you may need to change some default settings when using these shapes and mapping `fill`. In particular, discrete `fill` guides will be drawn with an unfilled shape unless overridden (refer to `geom_point()` for an example of this).
255255

256256
## Text
257257

0 commit comments

Comments
 (0)