fallback for invalid legend.position

teunbrand · teunbrand · commit f584b4021dde · 2025-01-22T15:52:40.000+01:00
diff --git a/R/guides-.R b/R/guides-.R
@@ -479,7 +479,7 @@ Guides <- ggproto(
     if (length(default_position) == 2) {
       default_position <- "inside"
     }
-    if (default_position == "none") {
+    if (!default_position %in% c(.trbl, "inside")) {
       return(zeroGrob())
     }
 
@@ -598,11 +598,7 @@ Guides <- ggproto(
     }
 
     # Determine default direction
-    direction <- switch(
-      position,
-      inside = , left = , right = "vertical",
-      top = , bottom = "horizontal"
-    )
+    direction <- switch(position, top = , bottom = "horizontal", "vertical")
 
     # Populate missing theme arguments
     theme$legend.box       <- theme$legend.box       %||% direction

Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,7 @@ Guides <- ggproto(`
`479`	`479`	`if (length(default_position) == 2) {`
`480`	`480`	`default_position <- "inside"`
`481`	`481`	`}`
`482`		`- if (default_position == "none") {`
	`482`	`+ if (!default_position %in% c(.trbl, "inside")) {`
`483`	`483`	`return(zeroGrob())`
`484`	`484`	`}`
`485`	`485`
`@@ -598,11 +598,7 @@ Guides <- ggproto(`
`598`	`598`	`}`
`599`	`599`
`600`	`600`	`# Determine default direction`
`601`		`- direction <- switch(`
`602`		`- position,`
`603`		`- inside = , left = , right = "vertical",`
`604`		`- top = , bottom = "horizontal"`
`605`		`- )`
	`601`	`+ direction <- switch(position, top = , bottom = "horizontal", "vertical")`
`606`	`602`
`607`	`603`	`# Populate missing theme arguments`
`608`	`604`	`theme$legend.box <- theme$legend.box %\|\|% direction`