defend against insanity

Author: teunbrand

R/theme-elements.R

@@ -492,8 +492,13 @@ S7::method(draw_element, element_text) <-
            hjust = NULL, vjust = NULL, angle = NULL, lineheight = NULL,
            margin = NULL, margin_x = FALSE, margin_y = FALSE, ...) {
 
-    if (is.null(label))
+    if (is.null(label)) {
       return(zeroGrob())
+    }
+    if (is_theme_element(label)) {
+      cli::cli_warn("{.arg label} cannot be {.obj_type_friendly {label}}.")
+      return(zeroGrob())
+    }
 
     vj <- vjust %||% element@vjust
     hj <- hjust %||% element@hjust

tests/testthat/_snaps/theme.md

@@ -115,6 +115,16 @@
       ! <ggplot2::element_text> object properties are invalid:
       - @colour cannot be a decimal number, but could be an integer.
 
+---
+
+    Code
+      element_grob(el, label = element_blank())
+    Condition
+      Warning:
+      `label` cannot be a <ggplot2::element_blank> object.
+    Output
+      zeroGrob[NULL] 
+
 # Theme validation behaves as expected
 
     The `aspect.ratio` theme element must be a <numeric/integer> object.

tests/testthat/test-theme.R

@@ -565,6 +565,13 @@ test_that("element_text throws appropriate conditions", {
     element_text(colour = sqrt(2)),
     error = TRUE
   )
+
+  # Some absurd case found in reverse dependency check where
+  # labs(y = element_blank()) for some reason
+  el <- theme_get()$text
+  expect_snapshot(
+    element_grob(el, label = element_blank())
+  )
 })
 
 test_that("Theme validation behaves as expected", {