notes for the future

teunbrand · teunbrand · commit ff12f377fc88 · 2025-05-23T14:39:19.000+02:00
diff --git a/R/plot-build.R b/R/plot-build.R
@@ -134,6 +134,7 @@ S7::method(build_ggplot, class_ggplot) <- function(plot, ...) {
   class_ggplot_built(data = data, layout = layout, plot = plot)
 }
 
+# TODO: the S3 generic should be phased out once S7 is adopted more widely
 #' @rdname build_ggplot
 #' @export
 ggplot_build <- function(plot, ...) {
diff --git a/R/plot-construction.R b/R/plot-construction.R
@@ -213,6 +213,7 @@ S7::method(update_ggplot, list(S7::new_S3_class("by"), class_ggplot)) <-
     ggplot_add(unclass(object), plot, object_name)
   }
 
+# TODO: the S3 generic should be phased out once S7 is adopted more widely
 # For backward compatibility, ggplot_add still exists but by default it wraps
 # `update_ggplot()`
 #' @rdname update_ggplot

Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,7 @@ S7::method(build_ggplot, class_ggplot) <- function(plot, ...) {`
`134`	`134`	`class_ggplot_built(data = data, layout = layout, plot = plot)`
`135`	`135`	`}`
`136`	`136`
	`137`	`+# TODO: the S3 generic should be phased out once S7 is adopted more widely`
`137`	`138`	`#' @rdname build_ggplot`
`138`	`139`	`#' @export`
`139`	`140`	`ggplot_build <- function(plot, ...) {`
Original file line number	Diff line number	Diff line change
`@@ -213,6 +213,7 @@ S7::method(update_ggplot, list(S7::new_S3_class("by"), class_ggplot)) <-`
`213`	`213`	`ggplot_add(unclass(object), plot, object_name)`
`214`	`214`	`}`
`215`	`215`
	`216`	`+# TODO: the S3 generic should be phased out once S7 is adopted more widely`
`216`	`217`	`# For backward compatibility, ggplot_add still exists but by default it wraps`
`217`	`218`	# `update_ggplot()`
`218`	`219`	`#' @rdname update_ggplot`