A big lint #6127
Closed
A big lint #6127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasp85
reviewed
Oct 28, 2024
|
No but I think lintr and tidyverse style guide share a lot of common ground. |
|
My guess is that this has now diverted too much from the main branch to be practical. I don't know if you wanna start afresh or update this PR |
|
Yeah it is probably best to do something like this just before a release. I'll close this for now and make a similar one later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a lot of small tweaks in the code based on a select few linters from the {lintr} package.
I didn't blindly obey all the linters; in some cases, the linter has been selectively ignored.
For example I didn't reindent/rewhitespace the
.element_treeconstruction because the whitespace facilitates vertical alignment.In other cases, I've chosen not to include some linters, like the cyclomatic complexity one, as ggproto classes were being counted as 1 big function.
I tried to group similar changes in the same commit so it is easy to undo some changes globally.