Centralise documentation for common layer arguments #6730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' into centralise_layer_arg_docs # Conflicts: # R/utilities-help.R # man/geom_bar.Rd # man/geom_boxplot.Rd # man/geom_density.Rd # man/geom_histogram.Rd # man/geom_linerange.Rd # man/geom_path.Rd # man/geom_ribbon.Rd # man/geom_smooth.Rd # man/geom_violin.Rd # man/stat_summary.Rd
thomasp85
approved these changes
Nov 18, 2025
Member
thomasp85
left a comment
thomasp85
left a comment
There was a problem hiding this comment.
If @noDoc still allows inheritance I think it is preferred over @keyword internal
| #' @keywords internal | ||
| #' @aliases NULL | ||
| NULL | ||
|
|
Member
There was a problem hiding this comment.
Does inheritance work while you use @noDoc?
Collaborator
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is upkeep and aims to fix a pet peeve.
The pet peeve is that there were multiple documentation entries for common parameters and tracking the inheritance of some layer parameters is a bit of a pain. This puts all the common parameters in one place. I also replaced the
rd_orientation()helper, as it essentially pasted a section that can also be just inherited.