Skip to content

Commit 1582af5

Browse files
hadleyhadley
committed
Re-check revdeps & update CRAN comments
1 parent ffcdcde commit 1582af5

File tree

4 files changed

+55
-190
lines changed

4 files changed

+55
-190
lines changed

‎cran-comments.md‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,9 @@
44

55
## revdepcheck results
66

7-
This is a patch release that mostly contains documentation improvements; I did not check revdeps.
7+
We checked 2390 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
8+
9+
* We saw 9 new problems
10+
* We failed to check 2 packages
11+
12+
We've been working with maintainers for over a month to get fixes to CRAN in a timely manner. You can track our efforts at <https://github.com/tidyverse/stringr/issues/590>.

‎revdep/README.md‎

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,17 @@
77
|DSMolgenisArmadillo |? | | | |
88
|multinma |0.8.1 |1 | | |
99

10-
## New problems (12)
10+
## New problems (9)
1111

12-
|package |version |error |warning |note |
13-
|:--------------|:-------|:------|:-------|:----|
14-
|[breathtestcore](problems.md#breathtestcore)|0.8.9 |__+1__ | |1 |
15-
|[echoice2](problems.md#echoice2)|0.2.4 |__+1__ | | |
12+
|package |version |error |warning |note |
13+
|:---------|:-------|:------|:-------|:----|
1614
|[huxtable](problems.md#huxtable)|5.7.0 |__+2__ | |1 |
1715
|[latex2exp](problems.md#latex2exp)|0.9.6 |__+2__ | | |
1816
|[NMsim](problems.md#nmsim)|0.2.5 |__+1__ | | |
1917
|[nrlR](problems.md#nrlr)|0.1.1 |__+1__ | | |
2018
|[phenofit](problems.md#phenofit)|0.3.10 |__+2__ | | |
21-
|[priceR](problems.md#pricer)|1.0.2 |__+1__ | | |
2219
|[psycModel](problems.md#psycmodel)|0.5.0 |__+1__ | |1 |
23-
|[reslr](problems.md#reslr)|0.1.1 |__+1__ | | |
2420
|[salty](problems.md#salty)|0.1.1 |__+2__ | | |
21+
|[sdbuildR](problems.md#sdbuildr)|1.0.7 |__+1__ | | |
2522
|[zipangu](problems.md#zipangu)|0.3.3 |__+1__ | |1 |
2623

‎revdep/cran.md‎

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,15 @@
11
## revdepcheck results
22

3-
We checked 2381 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
3+
We checked 2390 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
44

5-
* We saw 12 new problems
5+
* We saw 9 new problems
66
* We failed to check 2 packages
77

88
Issues with CRAN packages are summarised below.
99

1010
### New problems
1111
(This reports the first line of each new failure)
1212

13-
* breathtestcore
14-
checking tests ... ERROR
15-
16-
* echoice2
17-
checking examples ... ERROR
18-
1913
* huxtable
2014
checking examples ... ERROR
2115
checking tests ... ERROR
@@ -34,19 +28,16 @@ Issues with CRAN packages are summarised below.
3428
checking examples ... ERROR
3529
checking tests ... ERROR
3630

37-
* priceR
38-
checking examples ... ERROR
39-
4031
* psycModel
4132
checking tests ... ERROR
4233

43-
* reslr
44-
checking tests ... ERROR
45-
4634
* salty
4735
checking examples ... ERROR
4836
checking tests ... ERROR
4937

38+
* sdbuildR
39+
checking tests ... ERROR
40+
5041
* zipangu
5142
checking tests ... ERROR
5243

‎revdep/problems.md‎

Lines changed: 40 additions & 168 deletions
Original file line numberDiff line numberDiff line change
@@ -1,91 +1,3 @@
1-
# breathtestcore (0.8.9)
2-
3-
* GitHub: <https://github.com/dmenne/breathtestcore>
4-
* Email: <mailto:[email protected]>
5-
* GitHub mirror: <https://github.com/cran/breathtestcore>
6-
7-
Run `revdepcheck::cloud_details(, "breathtestcore")` for more info
8-
9-
## Newly broken
10-
11-
* checking tests ... ERROR
12-
```
13-
Running ‘test-all.R’
14-
Running the tests in ‘tests/test-all.R’ failed.
15-
Complete output:
16-
> library(testthat)
17-
>
18-
> #options(Ncpus = parallelly::availableCores(omit = 1))
19-
> #options(Ncpus = 1)
20-
> options(lifecycle_verbosity = "warning")
21-
> test_check("breathtestcore")
22-
Loading required package: breathtestcore
23-
Starting 2 test processes
24-
[ FAIL 1 | WARN 15 | SKIP 4 | PASS 362 ]
25-
26-
══ Skipped tests (4) ═══════════════════════════════════════════════════════════
27-
• On CRAN (4): 'test_coef_by_group.R:55:3', 'test_coef_diff_by_group.R:54:3',
28-
'test_read_iris_csv.R:49:3', 'test_plot_breathtestfit.R:49:3'
29-
30-
══ Failed tests ════════════════════════════════════════════════════════════════
31-
── Failure ('test_cleanup_data.R:178:3'): data from BreathId device is accepted as input ──
32-
`cleanup_data(data)` produced warnings.
33-
34-
[ FAIL 1 | WARN 15 | SKIP 4 | PASS 362 ]
35-
Error: Test failures
36-
Execution halted
37-
```
38-
39-
## In both
40-
41-
* checking DESCRIPTION meta-information ... NOTE
42-
```
43-
Missing dependency on R >= 4.1.0 because package code uses the pipe
44-
|> or function shorthand \(...) syntax added in R 4.1.0.
45-
File(s) using such syntax:
46-
‘read_any_breathtest.R’
47-
```
48-
49-
# echoice2 (0.2.4)
50-
51-
* GitHub: <https://github.com/ninohardt/echoice2>
52-
* Email: <mailto:[email protected]>
53-
* GitHub mirror: <https://github.com/cran/echoice2>
54-
55-
Run `revdepcheck::cloud_details(, "echoice2")` for more info
56-
57-
## Newly broken
58-
59-
* checking examples ... ERROR
60-
```
61-
...
62-
! `pattern` can not contain NAs.
63-
Backtrace:
64-
▆
65-
1. ├─echoice2::get_attr_lvl(dummied_data)
66-
2. │ └─... %>% rename(attr_level = value)
67-
3. ├─dplyr::rename(., attr_level = value)
68-
4. ├─dplyr::mutate(., lvl_abbrv = abbreviate(lvl))
69-
5. ├─dplyr::mutate(...)
70-
6. ├─dplyr::mutate(., reference_lvl = dplyr::first(lvl))
71-
7. ├─dplyr::group_by(., across("attribute"))
72-
8. ├─dplyr::mutate(., lvl = stringr::str_remove(.$lvl, "^(:)"))
73-
9. ├─dplyr::mutate(., lvl = stringr::str_remove(.$value, .$attribute))
74-
10. ├─dplyr:::mutate.data.frame(., lvl = stringr::str_remove(.$value, .$attribute))
75-
11. │ └─dplyr:::mutate_cols(.data, dplyr_quosures(...), by)
76-
12. │ ├─base::withCallingHandlers(...)
77-
13. │ └─dplyr:::mutate_col(dots[[i]], data, mask, new_columns)
78-
14. │ └─mask$eval_all_mutate(quo)
79-
15. │ └─dplyr (local) eval()
80-
16. └─stringr::str_remove(.$value, .$attribute)
81-
17. └─stringr::str_replace(string, pattern, "")
82-
18. ├─stringr:::type(pattern)
83-
19. └─stringr:::type.character(pattern)
84-
20. └─cli::cli_abort(tr_("{.arg pattern} can not contain NAs."), call = error_call)
85-
21. └─rlang::abort(...)
86-
Execution halted
87-
```
88-
891
# huxtable (5.7.0)
902

913
* GitHub: <https://github.com/hughjonesd/huxtable>
@@ -363,46 +275,6 @@ Run `revdepcheck::cloud_details(, "phenofit")` for more info
363275
Execution halted
364276
```
365277
366-
# priceR (1.0.2)
367-
368-
* GitHub: <https://github.com/stevecondylios/priceR>
369-
* Email: <mailto:[email protected]>
370-
* GitHub mirror: <https://github.com/cran/priceR>
371-
372-
Run `revdepcheck::cloud_details(, "priceR")` for more info
373-
374-
## Newly broken
375-
376-
* checking examples ... ERROR
377-
```
378-
...
379-
>
380-
> # Provide a salary string and 'extract_salary' and will extract the salary and return it
381-
> extract_salary("$160,000 per annum")
382-
salary
383-
1 160000
384-
> # 160000
385-
>
386-
>
387-
> # If a range is present, the average will be taken by default
388-
> extract_salary("$160,000 - $180000.00 per annum")
389-
Error in `str_replace_all()`:
390-
! `replacement` function must return a character vector, not an integer.
391-
Backtrace:
392-
▆
393-
1. ├─priceR::extract_salary("$160,000 - $180000.00 per annum")
394-
2. │ └─... %>% gsub("(\\d+)K", "\\1000", .)
395-
3. ├─base::gsub("(\\d+)K", "\\1000", .)
396-
4. │ └─base::is.factor(x)
397-
5. ├─base::gsub("(\\d+)k", "\\1000", .)
398-
6. │ └─base::is.factor(x)
399-
7. └─stringr::str_replace_all(...)
400-
8. └─stringr:::str_transform_all(string, pattern, replacement)
401-
9. └─cli::cli_abort(...)
402-
10. └─rlang::abort(...)
403-
Execution halted
404-
```
405-
406278
# psycModel (0.5.0)
407279
408280
* GitHub: <https://github.com/jasonmoy28/psycModel>
@@ -452,46 +324,6 @@ Run `revdepcheck::cloud_details(, "psycModel")` for more info
452324
All declared Imports should be used.
453325
```
454326
455-
# reslr (0.1.1)
456-
457-
* GitHub: <https://github.com/maeveupton/reslr>
458-
* Email: <mailto:[email protected]>
459-
* GitHub mirror: <https://github.com/cran/reslr>
460-
461-
Run `revdepcheck::cloud_details(, "reslr")` for more info
462-
463-
## Newly broken
464-
465-
* checking tests ... ERROR
466-
```
467-
...
468-
── Error ('test-test_reslr_load.R:76:3'): Simplest example with list of tide gauges ──
469-
Error in `utils::download.file(url, destfile = temp_file, quiet = TRUE)`: cannot open URL 'https://psmsl.org/data/obtaining/rlr.annual.data/rlr_annual.zip'
470-
Backtrace:
471-
▆
472-
1. └─reslr::reslr_load(...) at test-test_reslr_load.R:76:3
473-
2. └─reslr:::clean_tidal_gauge_data(...)
474-
3. └─utils::download.file(url, destfile = temp_file, quiet = TRUE)
475-
── Error ('test-test_reslr_load.R:98:3'): Simplest example with all tide gauges within 1 degree ──
476-
Error in `utils::download.file(url, destfile = temp_file, quiet = TRUE)`: cannot open URL 'https://psmsl.org/data/obtaining/rlr.annual.data/rlr_annual.zip'
477-
Backtrace:
478-
▆
479-
1. └─reslr::reslr_load(...) at test-test_reslr_load.R:98:3
480-
2. └─reslr:::clean_tidal_gauge_data(...)
481-
3. └─utils::download.file(url, destfile = temp_file, quiet = TRUE)
482-
── Error ('test-test_reslr_load.R:142:3'): Simplest example with linear rate and closes tide gauge ──
483-
Error in `utils::download.file(url, destfile = temp_file, quiet = TRUE)`: cannot open URL 'https://psmsl.org/data/obtaining/rlr.annual.data/rlr_annual.zip'
484-
Backtrace:
485-
▆
486-
1. └─reslr::reslr_load(...) at test-test_reslr_load.R:142:3
487-
2. └─reslr:::clean_tidal_gauge_data(...)
488-
3. └─utils::download.file(url, destfile = temp_file, quiet = TRUE)
489-
490-
[ FAIL 6 | WARN 7 | SKIP 1 | PASS 52 ]
491-
Error: Test failures
492-
Execution halted
493-
```
494-
495327
# salty (0.1.1)
496328
497329
* GitHub: <https://github.com/mdlincoln/salty>
@@ -562,6 +394,46 @@ Run `revdepcheck::cloud_details(, "salty")` for more info
562394
Execution halted
563395
```
564396
397+
# sdbuildR (1.0.7)
398+
399+
* GitHub: <https://github.com/KCEvers/sdbuildR>
400+
* Email: <mailto:[email protected]>
401+
* GitHub mirror: <https://github.com/cran/sdbuildR>
402+
403+
Run `revdepcheck::cloud_details(, "sdbuildR")` for more info
404+
405+
## Newly broken
406+
407+
* checking tests ... ERROR
408+
```
409+
...
410+
12. └─cli::cli_abort(...)
411+
13. └─rlang::abort(...)
412+
── Error ('test-conv_julia.R:723:3'): adding scientific notation ───────────────
413+
Error in `stringr::str_replace_all(eqn, pattern = pattern, replacement = reformat_scientific)`: Failed to apply `replacement` function.
414+
i It must accept a character vector of any length.
415+
Caused by error in `if (nchar(format(num, scientific = FALSE)) > digits_max) ...`:
416+
! the condition has length > 1
417+
Backtrace:
418+
▆
419+
1. ├─testthat::expect_equal(...) at test-conv_julia.R:723:3
420+
2. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
421+
3. │ └─rlang::eval_bare(expr, quo_get_env(quo))
422+
4. ├─sdbuildR:::scientific_notation("hiding 1e+23", task = "add")
423+
5. │ └─stringr::str_replace_all(eqn, pattern = pattern, replacement = reformat_scientific)
424+
6. │ └─stringr:::str_transform_all(string, pattern, replacement)
425+
7. │ ├─base::withCallingHandlers(...)
426+
8. │ └─sdbuildR (local) replacement(old_flat)
427+
9. └─base::.handleSimpleError(...)
428+
10. └─stringr (local) h(simpleError(msg, call))
429+
11. └─cli::cli_abort(...)
430+
12. └─rlang::abort(...)
431+
432+
[ FAIL 4 | WARN 0 | SKIP 30 | PASS 915 ]
433+
Error: Test failures
434+
Execution halted
435+
```
436+
565437
# zipangu (0.3.3)
566438
567439
* GitHub: <https://github.com/uribo/zipangu>

0 commit comments

Comments
 (0)