Respect modifiers of named vectors

Fixes #207

Author: hadley

NEWS.md

@@ -1,5 +1,7 @@
 # stringr 1.3.0.9000
 
+* `str_replace_all()` with a named vector now respects modifier functions (#207)
+
 * `str_trunc()` is once again vectorised correctly (#203, @austin3dickey).
 
 # stringr 1.3.0

R/replace.r

@@ -79,7 +79,7 @@ str_replace_all <- function(string, pattern, replacement) {
   if (!is.null(names(pattern))) {
     vec <- FALSE
     replacement <- unname(pattern)
-    pattern <- names(pattern)
+    pattern[] <- names(pattern)
   } else {
     vec <- TRUE
   }

tests/testthat/test-replace.r

@@ -40,6 +40,12 @@ test_that("can replace multiple matches", {
   expect_equal(y, c("11", "22"))
 })
 
+test_that("multiple matches respects class", {
+  x <- c("x", "y")
+  y <- str_replace_all(x, regex(c("X" = "a"), ignore_case = TRUE))
+  expect_equal(y, c("a", "y"))
+})
+
 test_that("replacement must be a string", {
   expect_error(str_replace("x", "x", 1), "must be a character vector")
 })