Fixed refit() method for ETS() models applying transformations twice

mitchelloharawild · mitchelloharawild · commit 01ec884b8821 · 2026-01-15T23:52:58.000+11:00
Resolves #407
diff --git a/NEWS.md b/NEWS.md
@@ -9,6 +9,7 @@
 
 * Fixed `VARIMA()` not working with integer data.
 * More robust calculations of `ARIMA()` AR and MA roots (#417).
+* Fixed `refit()` method for `ETS()` models applying transformations twice (#407).
 
 # fable 0.4.1
 
diff --git a/R/ets.R b/R/ets.R
@@ -447,9 +447,8 @@ refit.ETS <- function(object, new_data, specials = NULL, reestimate = FALSE, rei
     }
   }
 
-  y <- transmute(new_data, !!parse_expr(measured_vars(object$est)[1]))
-  idx <- unclass(y)[[index_var(y)]]
-  y <- unclass(y)[[measured_vars(y)]]
+  idx <- unclass(new_data)[[index_var(new_data)]]
+  y <- new_data[[measured_vars(new_data)]]
 
   best <- if (reinitialise) {
     etsmodel(

Original file line number	Diff line number	Diff line change
`@@ -447,9 +447,8 @@ refit.ETS <- function(object, new_data, specials = NULL, reestimate = FALSE, rei`
`447`	`447`	`}`
`448`	`448`	`}`
`449`	`449`
`450`		`- y <- transmute(new_data, !!parse_expr(measured_vars(object$est)[1]))`
`451`		`- idx <- unclass(y)[[index_var(y)]]`
`452`		`- y <- unclass(y)[[measured_vars(y)]]`
	`450`	`+ idx <- unclass(new_data)[[index_var(new_data)]]`
	`451`	`+ y <- new_data[[measured_vars(new_data)]]`
`453`	`452`
`454`	`453`	`best <- if (reinitialise) {`
`455`	`454`	`etsmodel(`