Skip to content

Commit e494612

Browse files
wrap level in categorical column in tuple (#20)
wrap level in categorical column in tuple to avoid splatting levels (e.g. strings)
1 parent 74c58d3 commit e494612

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/model_matrix.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ _feature_columns(cont_vars, cat_vars, f::LinearFeature, nk) = [ModelMatrixColumn
1212
_feature_columns(cont_vars, cat_vars, f::QuadraticFeature, nk) = [ModelMatrixColumn(f, k) for k in keys(cont_vars)]
1313
function _feature_columns(cont_vars, cat_vars, f::CategoricalFeature, nk)
1414
mapreduce(hcat, keys(cat_vars)) do k
15-
[ModelMatrixColumn(f, k, x) for x in CategoricalArrays.levels(cat_vars[k])]
15+
[ModelMatrixColumn(f, k, (x,)) for x in CategoricalArrays.levels(cat_vars[k])]
1616
end
1717
end
1818

test/runtests.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
using Maxnet, Test, Statistics
1+
using Maxnet, Test, Statistics, CategoricalArrays
22

33
p_a, env = Maxnet.bradypus()
4+
# Make the levels in ecoreg string to make sure that that works
5+
env = merge(env, (; ecoreg = recode(env.ecoreg, (l => string(l) for l in levels(env.ecoreg))...)))
46
env1 = map(e -> [e[1]], env) # just the first row
57

68
@testset "utils" begin

0 commit comments

Comments
 (0)