Merge pull request gitx#19 from nanotech/f/intconv

Fix incorrect implicit integer-pointer conversions

Author: ssp

Classes/Controllers/PBRepositoryDocumentController.m

@@ -42,8 +42,8 @@ - (id)makeUntitledDocumentOfType:(NSString *)typeName error:(NSError *__autorele
         return nil;
     }
 
-	BOOL success = [GTRepository initializeEmptyRepositoryAtFileURL:[op URL] options:nil error:outError];
-    if (!success)
+	GTRepository *repo = [GTRepository initializeEmptyRepositoryAtFileURL:[op URL] options:nil error:outError];
+    if (!repo)
         return nil; // Repo creation failed
 
     return [[PBGitRepositoryDocument alloc] initWithContentsOfURL:[op URL] ofType:PBGitRepositoryDocumentType error:outError];

Classes/Util/NSApplication+GitXScripting.m

@@ -57,8 +57,8 @@ - (void)initRepositoryScriptCommand:(NSScriptCommand *)command
 	if (!repositoryURL)
         return;
 
-	BOOL success = [GTRepository initializeEmptyRepositoryAtFileURL:repositoryURL options:nil error:&error];
-    if (!success) {
+	GTRepository *repo = [GTRepository initializeEmptyRepositoryAtFileURL:repositoryURL options:nil error:&error];
+    if (!repo) {
         NSLog(@"Failed to create repository at %@: %@", repositoryURL, error);
         return;
     }

Classes/git/PBGitRepository.m

@@ -535,8 +535,7 @@ - (PBGitStash *)stashForRef:(PBGitRef *)ref {
 		PBGitStash *stash = [[PBGitStash alloc] initWithRepository:self stashOID:oid index:index message:message];
         if ([stash.ref isEqualToRef:ref]) {
             found = stash;
-            stop = YES;
-			(void)stop;
+            *stop = YES;
         }
 	}];
     return found;
@@ -1125,8 +1124,7 @@ - (BOOL)executeHook:(NSString *)name arguments:(NSArray *)arguments output:(NSSt
 	NSString *hookPath = [[[[self gitURL] path] stringByAppendingPathComponent:@"hooks"] stringByAppendingPathComponent:name];
 	if (![[NSFileManager defaultManager] isExecutableFileAtPath:hookPath]) {
 		// XXX: Maybe return error ?
-		// We *
-		return @"";
+		return YES;
 	}
 
 	NSDictionary *info = @{

GitX.xcodeproj/project.pbxproj

@@ -1658,6 +1658,8 @@
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_BOOL_CONVERSION = YES;
+				CLANG_WARN_INT_CONVERSION = YES;
 				COPY_PHASE_STRIP = NO;
 				CURRENT_PROJECT_VERSION = 0.12;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
@@ -1686,6 +1688,8 @@
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_BOOL_CONVERSION = YES;
+				CLANG_WARN_INT_CONVERSION = YES;
 				CURRENT_PROJECT_VERSION = 0.12;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				GCC_PREPROCESSOR_DEFINITIONS = GITX_NO_DEPRECATE;