updates from code review

Signed-off-by: Ganga Ram <Ganga.Ram@tii.ae>

Author: gngram

modules/common/security/spire/server.nix

@@ -108,10 +108,16 @@ let
           echo "Agent ${vm} already registered, skipping token generation"
         else
           echo "Generating new token for ${vm}"
-          token="$(spire-server token generate \
-            -socketPath ${socketPath} \
-            -spiffeID spiffe://${cfg.trustDomain}/${vm} \
-            | awk '/^Token:/ {print $2}')"
+          output=$(spire-server token generate -socketPath "${socketPath}" -spiffeID "spiffe://${cfg.trustDomain}/${vm}")
+
+          # Check if the command actually worked
+          if [ $? -ne 0 ]; then
+              echo "Error: SPIRE token generation failed!" >&2
+              exit 1
+          fi
+
+          # Extract the token from the successful output
+          token=$(echo "$output" | awk '/^Token:/ {print $2}')
 
           printf '%s\n' "$token" > "$tokenFile"
           chmod 0644 "$tokenFile"