fix: linting

Author: kanfil

scripts/bash/detect-workflow-config.sh

@@ -20,10 +20,12 @@ detect_workflow_config() {
   fi
 
   # Extract mode (look for line: **Workflow Mode**: build|spec)
-  local mode_line=$(grep "^\*\*Workflow Mode\*\*:" "$spec_file" | head -1)
-  if [[ -n "$mode_line" ]]; then
-    mode=$(echo "$mode_line" | sed 's/.*: *\([^ ]*\).*/\1/' | tr -d '[:space:]')
-  fi
+local mode_line
+    mode_line=$(grep "^\*\*Workflow Mode\*\*:" "$spec_file" | head -1)
+    local mode="spec"
+    if [[ -n "$mode_line" ]]; then
+        mode=$(echo "$mode_line" | sed 's/.*: *\(.*\)/\1/' | tr -d '[:space:]')
+    fi
 
   # Validate mode (must be build or spec)
   if [[ ! "$mode" =~ ^(build|spec)$ ]]; then
@@ -40,21 +42,19 @@ detect_workflow_config() {
 
   # Extract and override with explicit options
   # Look for line: **Framework Options**: tdd=true, contracts=false, ...
-  local options_line=$(grep "^\*\*Framework Options\*\*:" "$spec_file" | head -1 | sed 's/.*: *\(.*\)/\1/')
-  
-  if [[ -n "$options_line" ]]; then
-    # Parse: tdd=true, contracts=false, data_models=true, risk_tests=true
-    local tdd_val=$(echo "$options_line" | grep -o "tdd=[^,]*" | cut -d= -f2 | tr -d '[:space:]')
-    local contracts_val=$(echo "$options_line" | grep -o "contracts=[^,]*" | cut -d= -f2 | tr -d '[:space:]')
-    local data_models_val=$(echo "$options_line" | grep -o "data_models=[^,]*" | cut -d= -f2 | tr -d '[:space:]')
-    local risk_tests_val=$(echo "$options_line" | grep -o "risk_tests=[^,]*" | cut -d= -f2 | tr -d '[:space:]')
+local options_line
+    options_line=$(grep "^\*\*Framework Options\*\*:" "$spec_file" | head -1 | sed 's/.*: *\(.*\)/\1/')
+    local tdd_val="true"
+    local contracts_val="true"
+    local data_models_val="true"
+    local risk_tests_val="true"
 
-    # Override defaults if explicitly set
-    [[ -n "$tdd_val" ]] && tdd="$tdd_val"
-    [[ -n "$contracts_val" ]] && contracts="$contracts_val"
-    [[ -n "$data_models_val" ]] && data_models="$data_models_val"
-    [[ -n "$risk_tests_val" ]] && risk_tests="$risk_tests_val"
-  fi
+    if [[ -n "$options_line" ]]; then
+        tdd_val=$(echo "$options_line" | grep -o "tdd=[^,]*" | cut -d= -f2 | tr -d '[:space:]')
+        contracts_val=$(echo "$options_line" | grep -o "contracts=[^,]*" | cut -d= -f2 | tr -d '[:space:]')
+        data_models_val=$(echo "$options_line" | grep -o "data_models=[^,]*" | cut -d= -f2 | tr -d '[:space:]')
+        risk_tests_val=$(echo "$options_line" | grep -o "risk_tests=[^,]*" | cut -d= -f2 | tr -d '[:space:]')
+    fi
 
   # Return as JSON
   echo "{\"mode\":\"$mode\",\"tdd\":$tdd,\"contracts\":$contracts,\"data_models\":$data_models,\"risk_tests\":$risk_tests}"

scripts/bash/setup-architecture.sh

@@ -58,7 +58,7 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 source "$SCRIPT_DIR/common.sh"
 
 # Get all paths and variables from common functions
-eval $(get_feature_paths)
+eval "$(get_feature_paths)"
 
 # Ensure the memory directory exists
 mkdir -p "$REPO_ROOT/memory"
@@ -161,15 +161,18 @@ detect_tech_stack() {
         tech_stack+="**Containerization**: Docker\n"
     fi
 
-    if [[ -d "kubernetes" ]] || [[ -d "k8s" ]] || [[ -f "*.yaml" ]] && grep -q "apiVersion:" *.yaml 2>/dev/null; then
+    local yaml_files=(*.yaml)
+    if [[ -d "kubernetes" ]] || [[ -d "k8s" ]] || [[ -f "${yaml_files[0]}" ]] && grep -q "apiVersion:" *.yaml 2>/dev/null; then
         tech_stack+="**Orchestration**: Kubernetes\n"
     fi
 
     if [[ -d "terraform" ]] || [[ -f "*.tf" ]]; then
         tech_stack+="**IaC**: Terraform\n"
     fi
 
-    if [[ -f ".github/workflows/"*.yml ]] || [[ -f ".github/workflows/"*.yaml ]]; then
+    local github_yml_files=(".github/workflows/"*.yml)
+    local github_yaml_files=(".github/workflows/"*.yaml)
+    if [[ -f "${github_yml_files[0]}" ]] || [[ -f "${github_yaml_files[0]}" ]]; then
         tech_stack+="**CI/CD**: GitHub Actions\n"
     fi
 

templates/commands/specify.md

@@ -36,6 +36,7 @@ Parse the following parameters from `$ARGUMENTS`:
 - `--no-risk-tests`: Disable risk-based testing (overrides mode default)
 
 **Mode-Specific Defaults**:
+
 - **Build Mode**: tdd=false, contracts=false, data_models=false, risk_tests=false
 - **Spec Mode**: tdd=true, contracts=true, data_models=true, risk_tests=true
 
@@ -45,7 +46,7 @@ After parsing, extract the feature description (everything after parameters).
 
 1. **Determine Effective Mode**: Parse `--mode` from arguments, default to "spec" if not specified
 
-2. **Determine Effective Options**: 
+2. **Determine Effective Options**:
    - Start with mode-specific defaults
    - Override with explicit flags (e.g., `--no-tdd` overrides default)
    - Pass to script as: `--mode build --tdd false --contracts false --data-models false --risk-tests false`