errors: remove cfg(clippy) GrpcAPI payload split

Signed-off-by: Michael Ingley <mingley@linkedin.com>

Author: Michael Ingley

examples/raw.rs

@@ -1,6 +1,7 @@
 // Copyright 2018 TiKV Project Authors. Licensed under Apache-2.0.
 
 #![type_length_limit = "8165158"]
+#![allow(clippy::result_large_err)]
 
 mod common;
 

src/common/errors.rs

@@ -8,11 +8,6 @@ use crate::proto::kvrpcpb;
 use crate::region::RegionVerId;
 use crate::BoundRange;
 
-#[cfg(clippy)]
-type GrpcApiErrorPayload = Box<tonic::Status>;
-#[cfg(not(clippy))]
-type GrpcApiErrorPayload = tonic::Status;
-
 /// Protobuf-generated region-level error returned by TiKV.
 ///
 /// This type is generated from TiKV's protobuf definitions and may change in a
@@ -73,7 +68,7 @@ pub enum Error {
     /// Wraps a `reqwest::Error`.
     /// Wraps a `grpcio::Error`.
     #[error("gRPC api error: {0}")]
-    GrpcAPI(GrpcApiErrorPayload),
+    GrpcAPI(tonic::Status),
     /// Wraps a `grpcio::Error`.
     #[error("url error: {0}")]
     Url(#[from] tonic::codegen::http::uri::InvalidUri),
@@ -149,23 +144,13 @@ impl From<ProtoKeyError> for Error {
 
 impl From<tonic::Status> for Error {
     fn from(status: tonic::Status) -> Error {
-        Error::GrpcAPI(grpc_api_error_payload(status))
+        Error::GrpcAPI(status)
     }
 }
 
 /// A result holding an [`Error`](enum@Error).
 pub type Result<T> = result::Result<T, Error>;
 
-#[cfg(clippy)]
-fn grpc_api_error_payload(status: tonic::Status) -> GrpcApiErrorPayload {
-    Box::new(status)
-}
-
-#[cfg(not(clippy))]
-fn grpc_api_error_payload(status: tonic::Status) -> GrpcApiErrorPayload {
-    status
-}
-
 #[doc(hidden)]
 #[macro_export]
 macro_rules! internal_err {
@@ -200,7 +185,6 @@ mod test {
     }
 
     #[test]
-    #[cfg(not(clippy))]
     fn grpc_api_variant_accepts_tonic_status_payload() {
         let error = Error::GrpcAPI(tonic::Status::new(Code::DeadlineExceeded, "timeout"));
         let Error::GrpcAPI(status) = error else {

src/lib.rs

@@ -91,6 +91,7 @@
 //! ```
 
 #![allow(clippy::field_reassign_with_default)]
+#![allow(clippy::result_large_err)]
 
 pub mod backoff;
 #[doc(hidden)]