make check

Signed-off-by: iosmanthus <[email protected]>

Author: iosmanthus

src/raw/requests.rs

@@ -1,6 +1,6 @@
 // Copyright 2019 TiKV Project Authors. Licensed under Apache-2.0.
 
-use std::{any::Any, borrow::Cow, ops::Range, sync::Arc};
+use std::{any::Any, ops::Range, sync::Arc};
 
 use async_trait::async_trait;
 use futures::stream::BoxStream;

src/request/codec.rs

@@ -49,10 +49,9 @@ pub trait RequestCodec: Sized + Clone + Sync + Send + 'static {
     }
 
     fn decode_keys(&self, keys: Vec<Vec<u8>>) -> Result<Vec<Vec<u8>>> {
-        Ok(keys
-            .into_iter()
+        keys.into_iter()
             .map(|key| self.decode_key(key))
-            .collect::<Result<Vec<Vec<u8>>>>()?)
+            .collect::<Result<Vec<Vec<u8>>>>()
     }
 
     fn decode_pairs(&self, mut pairs: Vec<kvrpcpb::KvPair>) -> Result<Vec<kvrpcpb::KvPair>> {
@@ -167,16 +166,15 @@ impl From<KeySpaceCodec> for Prefix {
 
 impl RequestCodec for KeySpaceCodec {
     fn encode_key(&self, mut key: Vec<u8>) -> Vec<u8> {
-        let this = self.clone();
         let mut encoded = Vec::with_capacity(key.len() + KEYSPACE_PREFIX_LEN);
-        let prefix: Prefix = this.into();
+        let prefix: Prefix = (*self).into();
         encoded.extend_from_slice(&prefix);
         encoded.append(&mut key);
         encoded
     }
 
     fn decode_key(&self, mut key: Vec<u8>) -> Result<Vec<u8>> {
-        let prefix: Prefix = self.clone().into();
+        let prefix: Prefix = (*self).into();
 
         if !key.starts_with(&prefix) {
             return Err(Error::CorruptedKeyspace {

src/request/mod.rs

@@ -1,7 +1,5 @@
 // Copyright 2019 TiKV Project Authors. Licensed under Apache-2.0.
 
-use std::borrow::Cow;
-
 use async_trait::async_trait;
 use derive_new::new;
 
@@ -35,7 +33,7 @@ pub trait KvRequest<C>: Request + Sized + Clone + Sync + Send + 'static {
     type Response: HasKeyErrors + HasLocks + HasRegionError + Clone + Send + 'static;
 
     fn encode_request(self, _codec: &C) -> Self {
-        self.clone()
+        self
     }
 
     fn decode_response(&self, _codec: &C, resp: Self::Response) -> crate::Result<Self::Response> {
@@ -80,7 +78,7 @@ macro_rules! impl_kv_request_for_batch_get {
                 &self,
                 codec: &C,
                 mut resp: Self::Response,
-            ) -> crate::Result<Self::Response> {
+            ) -> $crate::Result<Self::Response> {
                 *resp.mut_pairs() = codec.decode_pairs(resp.take_pairs())?;
 
                 Ok(resp)
@@ -112,7 +110,7 @@ macro_rules! impl_kv_request_for_scan_op {
                 &self,
                 codec: &C,
                 mut resp: Self::Response,
-            ) -> crate::Result<Self::Response> {
+            ) -> $crate::Result<Self::Response> {
                 paste::paste! {
                     let pairs = resp.[<take_ $pairs>]();
 

src/transaction/requests.rs

@@ -1,5 +1,5 @@
 // Copyright 2020 TiKV Project Authors. Licensed under Apache-2.0.
-use std::{borrow::Cow, collections::HashMap, iter, sync::Arc};
+use std::{collections::HashMap, iter, sync::Arc};
 
 use either::Either;
 use futures::stream::BoxStream;
@@ -9,7 +9,6 @@ use tikv_client_proto::{
     kvrpcpb::{self, TxnHeartBeatResponse},
     pdpb::Timestamp,
 };
-use tikv_client_store::Request;
 
 use crate::{
     collect_first,
@@ -21,7 +20,6 @@ use crate::{
     store::{store_stream_for_keys, store_stream_for_range_by_start_key, RegionStore},
     timestamp::TimestampExt,
     transaction::HasLocks,
-    transaction_lowering::PessimisticLock,
     util::iter::FlatMapOkIterExt,
     Key, KvPair, Result, Value,
 };