Skip to content

Commit cb03278

Browse files
committed
Add extent_grow_mtx in pre_ / post_fork handlers.
This fixed the issue that could cause the child process to stuck after fork.
1 parent 2b31cf5 commit cb03278

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

include/jemalloc/internal/arena_externs.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ void arena_prefork3(tsdn_t *tsdn, arena_t *arena);
9090
void arena_prefork4(tsdn_t *tsdn, arena_t *arena);
9191
void arena_prefork5(tsdn_t *tsdn, arena_t *arena);
9292
void arena_prefork6(tsdn_t *tsdn, arena_t *arena);
93+
void arena_prefork7(tsdn_t *tsdn, arena_t *arena);
9394
void arena_postfork_parent(tsdn_t *tsdn, arena_t *arena);
9495
void arena_postfork_child(tsdn_t *tsdn, arena_t *arena);
9596

src/arena.c

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2087,28 +2087,33 @@ arena_prefork1(tsdn_t *tsdn, arena_t *arena) {
20872087

20882088
void
20892089
arena_prefork2(tsdn_t *tsdn, arena_t *arena) {
2090+
malloc_mutex_prefork(tsdn, &arena->extent_grow_mtx);
2091+
}
2092+
2093+
void
2094+
arena_prefork3(tsdn_t *tsdn, arena_t *arena) {
20902095
extents_prefork(tsdn, &arena->extents_dirty);
20912096
extents_prefork(tsdn, &arena->extents_muzzy);
20922097
extents_prefork(tsdn, &arena->extents_retained);
20932098
}
20942099

20952100
void
2096-
arena_prefork3(tsdn_t *tsdn, arena_t *arena) {
2101+
arena_prefork4(tsdn_t *tsdn, arena_t *arena) {
20972102
malloc_mutex_prefork(tsdn, &arena->extent_avail_mtx);
20982103
}
20992104

21002105
void
2101-
arena_prefork4(tsdn_t *tsdn, arena_t *arena) {
2106+
arena_prefork5(tsdn_t *tsdn, arena_t *arena) {
21022107
base_prefork(tsdn, arena->base);
21032108
}
21042109

21052110
void
2106-
arena_prefork5(tsdn_t *tsdn, arena_t *arena) {
2111+
arena_prefork6(tsdn_t *tsdn, arena_t *arena) {
21072112
malloc_mutex_prefork(tsdn, &arena->large_mtx);
21082113
}
21092114

21102115
void
2111-
arena_prefork6(tsdn_t *tsdn, arena_t *arena) {
2116+
arena_prefork7(tsdn_t *tsdn, arena_t *arena) {
21122117
for (unsigned i = 0; i < NBINS; i++) {
21132118
malloc_mutex_prefork(tsdn, &arena->bins[i].lock);
21142119
}
@@ -2127,6 +2132,7 @@ arena_postfork_parent(tsdn_t *tsdn, arena_t *arena) {
21272132
extents_postfork_parent(tsdn, &arena->extents_dirty);
21282133
extents_postfork_parent(tsdn, &arena->extents_muzzy);
21292134
extents_postfork_parent(tsdn, &arena->extents_retained);
2135+
malloc_mutex_postfork_parent(tsdn, &arena->extent_grow_mtx);
21302136
malloc_mutex_postfork_parent(tsdn, &arena->decay_dirty.mtx);
21312137
malloc_mutex_postfork_parent(tsdn, &arena->decay_muzzy.mtx);
21322138
if (config_stats) {
@@ -2164,6 +2170,7 @@ arena_postfork_child(tsdn_t *tsdn, arena_t *arena) {
21642170
extents_postfork_child(tsdn, &arena->extents_dirty);
21652171
extents_postfork_child(tsdn, &arena->extents_muzzy);
21662172
extents_postfork_child(tsdn, &arena->extents_retained);
2173+
malloc_mutex_postfork_child(tsdn, &arena->extent_grow_mtx);
21672174
malloc_mutex_postfork_child(tsdn, &arena->decay_dirty.mtx);
21682175
malloc_mutex_postfork_child(tsdn, &arena->decay_muzzy.mtx);
21692176
if (config_stats) {

src/jemalloc.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3049,7 +3049,7 @@ _malloc_prefork(void)
30493049
background_thread_prefork1(tsd_tsdn(tsd));
30503050
}
30513051
/* Break arena prefork into stages to preserve lock order. */
3052-
for (i = 0; i < 7; i++) {
3052+
for (i = 0; i < 8; i++) {
30533053
for (j = 0; j < narenas; j++) {
30543054
if ((arena = arena_get(tsd_tsdn(tsd), j, false)) !=
30553055
NULL) {
@@ -3075,6 +3075,9 @@ _malloc_prefork(void)
30753075
case 6:
30763076
arena_prefork6(tsd_tsdn(tsd), arena);
30773077
break;
3078+
case 7:
3079+
arena_prefork7(tsd_tsdn(tsd), arena);
3080+
break;
30783081
default: not_reached();
30793082
}
30803083
}

0 commit comments

Comments
 (0)