Skip to content

Commit 02be5a7

Browse files
committed
Migrate all testing code to prost
Signed-off-by: Folyd <[email protected]>
1 parent 35493eb commit 02be5a7

File tree

8 files changed

+65
-62
lines changed

8 files changed

+65
-62
lines changed

src/counter.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -343,9 +343,9 @@ mod tests {
343343
assert_eq!(mfs.len(), 1);
344344

345345
let mf = mfs.pop().unwrap();
346-
let m = mf.get_metric().get(0).unwrap();
347-
assert_eq!(m.get_label().len(), 2);
348-
assert_eq!(m.get_counter().get_value() as u64, 43);
346+
let m = mf.metric.get(0).unwrap();
347+
assert_eq!(m.label.len(), 2);
348+
assert_eq!(m.counter.as_ref().unwrap().value.unwrap_or(0.0) as u64, 43);
349349

350350
counter.reset();
351351
assert_eq!(counter.get() as u64, 0);
@@ -363,9 +363,9 @@ mod tests {
363363
assert_eq!(mfs.len(), 1);
364364

365365
let mf = mfs.pop().unwrap();
366-
let m = mf.get_metric().get(0).unwrap();
367-
assert_eq!(m.get_label().len(), 0);
368-
assert_eq!(m.get_counter().get_value() as u64, 12);
366+
let m = mf.metric.get(0).unwrap();
367+
assert_eq!(m.label.len(), 0);
368+
assert_eq!(m.counter.as_ref().unwrap().value.unwrap_or(0.0) as u64, 12);
369369

370370
counter.reset();
371371
assert_eq!(counter.get() as u64, 0);

src/encoder/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ mod tests {
6767
let mut mfs = cv.collect();
6868

6969
// Empty name
70-
(&mut mfs[0]).clear_name();
70+
(&mut mfs[0]).name.take();
7171
check_metric_family(&mfs[0]).unwrap_err();
7272
pb_encoder.encode(&mfs, &mut writer).unwrap_err();
7373
assert_eq!(writer.len(), 0);
@@ -94,7 +94,7 @@ mod tests {
9494
let mut mfs = cv.collect();
9595

9696
// Empty name
97-
(&mut mfs[0]).clear_name();
97+
(&mut mfs[0]).name.take();
9898
check_metric_family(&mfs[0]).unwrap_err();
9999
text_encoder.encode(&mfs, &mut writer).unwrap_err();
100100
assert_eq!(writer.len(), 0);

src/encoder/text.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ test_histogram_count{a="1"} 1
401401
let mut metric_family = MetricFamily::default();
402402
metric_family.name = Some("test_summary".to_string());
403403
metric_family.help = Some("This is a test summary statistic".to_string());
404-
metric_family.r#type = Some(MetricType::Summary);
404+
metric_family.r#type = Some(MetricType::Summary.into());
405405

406406
let mut summary = Summary::default();
407407
summary.sample_count = Some(5.0 as u64);

src/gauge.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,9 @@ mod tests {
188188
assert_eq!(mfs.len(), 1);
189189

190190
let mf = mfs.pop().unwrap();
191-
let m = mf.get_metric().get(0).unwrap();
192-
assert_eq!(m.get_label().len(), 2);
193-
assert_eq!(m.get_gauge().get_value() as u64, 42);
191+
let m = mf.metric.get(0).unwrap();
192+
assert_eq!(m.label.len(), 2);
193+
assert_eq!(m.gauge.as_ref().unwrap().value.unwrap_or(0.0) as u64, 42);
194194
}
195195

196196
#[test]

src/histogram.rs

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1236,12 +1236,12 @@ mod tests {
12361236
assert_eq!(mfs.len(), 1);
12371237

12381238
let mf = mfs.pop().unwrap();
1239-
let m = mf.get_metric().get(0).unwrap();
1240-
assert_eq!(m.get_label().len(), 2);
1241-
let proto_histogram = m.get_histogram();
1242-
assert_eq!(proto_histogram.get_sample_count(), 3);
1243-
assert!(proto_histogram.get_sample_sum() >= 1.5);
1244-
assert_eq!(proto_histogram.get_bucket().len(), DEFAULT_BUCKETS.len());
1239+
let m = mf.metric.get(0).unwrap();
1240+
assert_eq!(m.label.len(), 2);
1241+
let proto_histogram = m.histogram.as_ref().unwrap();
1242+
assert_eq!(proto_histogram.sample_count.unwrap_or(0), 3);
1243+
assert!(proto_histogram.sample_sum.unwrap_or(0.0) >= 1.5);
1244+
assert_eq!(proto_histogram.bucket.len(), DEFAULT_BUCKETS.len());
12451245

12461246
let buckets = vec![1.0, 2.0, 3.0];
12471247
let opts = HistogramOpts::new("test2", "test help").buckets(buckets.clone());
@@ -1250,12 +1250,12 @@ mod tests {
12501250
assert_eq!(mfs.len(), 1);
12511251

12521252
let mf = mfs.pop().unwrap();
1253-
let m = mf.get_metric().get(0).unwrap();
1254-
assert_eq!(m.get_label().len(), 0);
1255-
let proto_histogram = m.get_histogram();
1256-
assert_eq!(proto_histogram.get_sample_count(), 0);
1257-
assert!((proto_histogram.get_sample_sum() - 0.0) < EPSILON);
1258-
assert_eq!(proto_histogram.get_bucket().len(), buckets.len())
1253+
let m = mf.metric.get(0).unwrap();
1254+
assert_eq!(m.label.len(), 0);
1255+
let proto_histogram = m.histogram.as_ref().unwrap();
1256+
assert_eq!(proto_histogram.sample_count.unwrap_or(0), 0);
1257+
assert!((proto_histogram.sample_sum.unwrap_or(0.0) - 0.0) < EPSILON);
1258+
assert_eq!(proto_histogram.bucket.len(), buckets.len())
12591259
}
12601260

12611261
#[test]
@@ -1400,12 +1400,12 @@ mod tests {
14001400
histogram.observe(1.0);
14011401

14021402
let m = histogram.metric();
1403-
assert_eq!(m.get_label().len(), labels.len());
1403+
assert_eq!(m.label.len(), labels.len());
14041404

1405-
let proto_histogram = m.get_histogram();
1406-
assert_eq!(proto_histogram.get_sample_count(), 1);
1407-
assert!((proto_histogram.get_sample_sum() - 1.0) < EPSILON);
1408-
assert_eq!(proto_histogram.get_bucket().len(), buckets.len())
1405+
let proto_histogram = m.histogram.unwrap();
1406+
assert_eq!(proto_histogram.sample_count.unwrap_or(0), 1);
1407+
assert!((proto_histogram.sample_sum.unwrap_or(0.0) - 1.0) < EPSILON);
1408+
assert_eq!(proto_histogram.bucket.len(), buckets.len())
14091409
}
14101410

14111411
#[test]
@@ -1418,9 +1418,9 @@ mod tests {
14181418

14191419
let check = |count, sum| {
14201420
let m = histogram.metric();
1421-
let proto_histogram = m.get_histogram();
1422-
assert_eq!(proto_histogram.get_sample_count(), count);
1423-
assert!((proto_histogram.get_sample_sum() - sum) < EPSILON);
1421+
let proto_histogram = m.histogram.unwrap();
1422+
assert_eq!(proto_histogram.sample_count.unwrap_or(0), count);
1423+
assert!((proto_histogram.sample_sum.unwrap_or(0.0) - sum) < EPSILON);
14241424
};
14251425

14261426
local.observe(1.0);
@@ -1452,10 +1452,10 @@ mod tests {
14521452
local_vec.remove_label_values(&["v1", "v2"]).unwrap_err();
14531453

14541454
let check = |count, sum| {
1455-
let ms = vec.collect()[0].take_metric();
1456-
let proto_histogram = ms[0].get_histogram();
1457-
assert_eq!(proto_histogram.get_sample_count(), count);
1458-
assert!((proto_histogram.get_sample_sum() - sum) < EPSILON);
1455+
let ms = &vec.collect()[0].metric;
1456+
let proto_histogram = &ms[0].histogram.as_ref().unwrap();
1457+
assert_eq!(proto_histogram.sample_count.unwrap_or(0), count);
1458+
assert!((proto_histogram.sample_sum.unwrap_or(0.0) - sum) < EPSILON);
14591459
};
14601460

14611461
{
@@ -1509,13 +1509,13 @@ mod tests {
15091509
let mut cumulative_count = 0;
15101510
let mut sample_sum = 0;
15111511
for _ in 0..1_000_000 {
1512-
let metric = &histogram.collect()[0].take_metric()[0];
1513-
let proto = metric.get_histogram();
1512+
let metric = &histogram.collect()[0].metric[0];
1513+
let proto = metric.histogram.as_ref().unwrap();
15141514

1515-
sample_count = proto.get_sample_count();
1516-
sample_sum = proto.get_sample_sum() as u64;
1515+
sample_count = proto.sample_count.unwrap_or(0);
1516+
sample_sum = proto.sample_sum.unwrap_or(0.0) as u64;
15171517
// There is only one bucket thus the `[0]`.
1518-
cumulative_count = proto.get_bucket()[0].get_cumulative_count();
1518+
cumulative_count = proto.bucket[0].cumulative_count.unwrap_or(0);
15191519

15201520
if sample_count != cumulative_count {
15211521
break;

src/metrics.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,8 @@ mod tests {
221221

222222
fn new_label_pair(name: &str, value: &str) -> LabelPair {
223223
let mut l = LabelPair::default();
224-
l.set_name(name.to_owned());
225-
l.set_value(value.to_owned());
224+
l.name = Some(name.to_owned());
225+
l.value = Some(value.to_owned());
226226
l
227227
}
228228

src/registry.rs

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -416,9 +416,9 @@ mod tests {
416416

417417
let mfs = r.gather();
418418
assert_eq!(mfs.len(), 3);
419-
assert_eq!(mfs[0].get_name(), "test_2_counter");
420-
assert_eq!(mfs[1].get_name(), "test_a_counter");
421-
assert_eq!(mfs[2].get_name(), "test_b_counter");
419+
assert_eq!(mfs[0].name, Some("test_2_counter".into()));
420+
assert_eq!(mfs[1].name, Some("test_a_counter".into()));
421+
assert_eq!(mfs[2].name, Some("test_b_counter".into()));
422422

423423
let r = Registry::new();
424424
let opts = Opts::new("test", "test help")
@@ -470,12 +470,12 @@ mod tests {
470470

471471
let mfs = r.gather();
472472
assert_eq!(mfs.len(), 1);
473-
let ms = mfs[0].get_metric();
473+
let ms = &mfs[0].metric;
474474
assert_eq!(ms.len(), 4);
475-
assert_eq!(ms[0].get_counter().get_value() as u64, 2);
476-
assert_eq!(ms[1].get_counter().get_value() as u64, 1);
477-
assert_eq!(ms[2].get_counter().get_value() as u64, 3);
478-
assert_eq!(ms[3].get_counter().get_value() as u64, 4);
475+
assert_eq!(ms[0].counter.as_ref().unwrap().value.unwrap() as u64, 2);
476+
assert_eq!(ms[1].counter.as_ref().unwrap().value.unwrap() as u64, 1);
477+
assert_eq!(ms[2].counter.as_ref().unwrap().value.unwrap() as u64, 3);
478+
assert_eq!(ms[3].counter.as_ref().unwrap().value.unwrap() as u64, 4);
479479
}
480480

481481
#[test]
@@ -488,7 +488,7 @@ mod tests {
488488

489489
let mfs = r.gather();
490490
assert_eq!(mfs.len(), 1);
491-
assert_eq!(mfs[0].get_name(), "common_prefix_test_a_counter");
491+
assert_eq!(mfs[0].name, Some("common_prefix_test_a_counter".into()));
492492
}
493493

494494
#[test]
@@ -508,19 +508,19 @@ mod tests {
508508

509509
let mfs = r.gather();
510510
assert_eq!(mfs.len(), 2);
511-
assert_eq!(mfs[0].get_name(), "test_a_counter");
512-
assert_eq!(mfs[1].get_name(), "test_vec");
511+
assert_eq!(mfs[0].name, Some("test_a_counter".into()));
512+
assert_eq!(mfs[1].name, Some("test_vec".into()));
513513

514514
let mut needle = proto::LabelPair::default();
515-
needle.set_name("tkey".to_string());
516-
needle.set_value("tvalue".to_string());
517-
let metrics = mfs[0].get_metric();
515+
needle.name = Some("tkey".to_string());
516+
needle.value = Some("tvalue".to_string());
517+
let metrics = &mfs[0].metric;
518518
for m in metrics {
519-
assert!(m.get_label().contains(&needle));
519+
assert!(m.label.contains(&needle));
520520
}
521-
let metrics = mfs[1].get_metric();
521+
let metrics = &mfs[1].metric;
522522
for m in metrics {
523-
assert!(m.get_label().contains(&needle));
523+
assert!(m.label.contains(&needle));
524524
}
525525
}
526526

src/vec.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -425,10 +425,13 @@ mod tests {
425425
labels.insert("c", "a");
426426
let c = vec.get_metric_with(&labels).unwrap();
427427
let m = c.metric();
428-
let label_pairs = m.get_label();
428+
let label_pairs = m.label;
429429
assert_eq!(label_pairs.len(), labels.len());
430430
for lp in label_pairs.iter() {
431-
assert_eq!(lp.get_value(), labels[lp.get_name()]);
431+
assert_eq!(
432+
lp.value.as_ref().unwrap(),
433+
labels[lp.name.as_ref().unwrap().as_str()]
434+
);
432435
}
433436
}
434437
}

0 commit comments

Comments
 (0)