Make the 'Reveal Players' effect ephemeral

Duration is set to 6 seconds

Author: miredirex

Code/client/Services/Generic/MagicService.cpp

@@ -465,21 +465,38 @@ void MagicService::ApplyQueuedEffects() noexcept
 
 void MagicService::UpdateRevealOtherPlayersEffect() noexcept
 {
-    if (GetAsyncKeyState(VK_F4) & 0x01)
-        m_revealOtherPlayers = !m_revealOtherPlayers;
+    constexpr auto cRevealDuration = 6s;
+    constexpr auto cDelayBetweenUpdates = 2s;
 
-    if (!m_revealOtherPlayers)
-        return;
+    // Effect's activation and lifecycle
 
+    static std::chrono::steady_clock::time_point revealStartTimePoint;
     static std::chrono::steady_clock::time_point lastSendTimePoint;
-    constexpr auto cDelayBetweenUpdates = 2s;
+
+    if (GetAsyncKeyState(VK_F4) & 0x01 && !m_revealingOtherPlayers)
+    {
+        m_revealingOtherPlayers = true;
+        revealStartTimePoint = std::chrono::steady_clock::now();
+    }
+
+    if (!m_revealingOtherPlayers)
+        return;
 
     const auto now = std::chrono::steady_clock::now();
+
+    if (now - revealStartTimePoint > cRevealDuration)
+    {
+        m_revealingOtherPlayers = false;
+        return;
+    }
+
     if (now - lastSendTimePoint < cDelayBetweenUpdates)
         return;
 
     lastSendTimePoint = now;
 
+    // When active
+
     Mod* pSkyrimTogether = ModManager::Get()->GetByName("SkyrimTogether.esp");
     if (!pSkyrimTogether)
         return;

Code/client/Services/MagicService.h

@@ -88,7 +88,7 @@ struct MagicService
     Map<uint32_t, AddTargetRequest> m_queuedEffects;
     Map<uint32_t, NotifyAddTarget> m_queuedRemoteEffects;
 
-    bool m_revealOtherPlayers = false;
+    bool m_revealingOtherPlayers = false;
 
     entt::scoped_connection m_updateConnection;
     entt::scoped_connection m_spellCastEventConnection;