Fix quest operator== that can rarely cause failure to progress quest (#815)

rfortier · web-flow · commit 84e7461e2945 · 2025-10-16T14:02:30.000+02:00
Co-authored-by: Richard Fortier &lt;rfortier@ourchateau.net&gt;
diff --git a/Code/encoding/Messages/NotifyQuestUpdate.h b/Code/encoding/Messages/NotifyQuestUpdate.h
@@ -15,7 +15,7 @@ struct NotifyQuestUpdate final : ServerMessage
     void SerializeRaw(TiltedPhoques::Buffer::Writer& aWriter) const noexcept override;
     void DeserializeRaw(TiltedPhoques::Buffer::Reader& aReader) noexcept override;
 
-    bool operator==(const NotifyQuestUpdate& acRhs) const noexcept { return GetOpcode() == acRhs.GetOpcode() && Id == acRhs.Id && Stage == acRhs.Stage && Status == acRhs.Stage; }
+    bool operator==(const NotifyQuestUpdate& acRhs) const noexcept { return GetOpcode() == acRhs.GetOpcode() && Id == acRhs.Id && Stage == acRhs.Stage && Status == acRhs.Status; }
 
     enum StatusCode : uint8_t
     {
diff --git a/Code/encoding/Messages/RequestQuestUpdate.h b/Code/encoding/Messages/RequestQuestUpdate.h
@@ -15,7 +15,7 @@ struct RequestQuestUpdate final : ClientMessage
     void SerializeRaw(TiltedPhoques::Buffer::Writer& aWriter) const noexcept override;
     void DeserializeRaw(TiltedPhoques::Buffer::Reader& aReader) noexcept override;
 
-    bool operator==(const RequestQuestUpdate& acRhs) const noexcept { return GetOpcode() == acRhs.GetOpcode() && Id == acRhs.Id && Stage == acRhs.Stage && Status == acRhs.Stage; }
+    bool operator==(const RequestQuestUpdate& acRhs) const noexcept { return GetOpcode() == acRhs.GetOpcode() && Id == acRhs.Id && Stage == acRhs.Stage && Status == acRhs.Status; }
 
     enum StatusCode : uint8_t
     {

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ struct NotifyQuestUpdate final : ServerMessage`
`15`	`15`	`void SerializeRaw(TiltedPhoques::Buffer::Writer& aWriter) const noexcept override;`
`16`	`16`	`void DeserializeRaw(TiltedPhoques::Buffer::Reader& aReader) noexcept override;`
`17`	`17`
`18`		`- bool operator==(const NotifyQuestUpdate& acRhs) const noexcept { return GetOpcode() == acRhs.GetOpcode() && Id == acRhs.Id && Stage == acRhs.Stage && Status == acRhs.Stage; }`
	`18`	`+ bool operator==(const NotifyQuestUpdate& acRhs) const noexcept { return GetOpcode() == acRhs.GetOpcode() && Id == acRhs.Id && Stage == acRhs.Stage && Status == acRhs.Status; }`
`19`	`19`
`20`	`20`	`enum StatusCode : uint8_t`
`21`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ struct RequestQuestUpdate final : ClientMessage`
`15`	`15`	`void SerializeRaw(TiltedPhoques::Buffer::Writer& aWriter) const noexcept override;`
`16`	`16`	`void DeserializeRaw(TiltedPhoques::Buffer::Reader& aReader) noexcept override;`
`17`	`17`
`18`		`- bool operator==(const RequestQuestUpdate& acRhs) const noexcept { return GetOpcode() == acRhs.GetOpcode() && Id == acRhs.Id && Stage == acRhs.Stage && Status == acRhs.Stage; }`
	`18`	`+ bool operator==(const RequestQuestUpdate& acRhs) const noexcept { return GetOpcode() == acRhs.GetOpcode() && Id == acRhs.Id && Stage == acRhs.Stage && Status == acRhs.Status; }`
`19`	`19`
`20`	`20`	`enum StatusCode : uint8_t`
`21`	`21`	`{`