Fix issues with self closing tags (closes #159)

Author: tim-gromeyer

src/html2md.cpp

@@ -431,7 +431,14 @@ bool Converter::ParseCharInTag(char ch) {
       current_tag_.pop_back();
     }
     skipping_leading_whitespace = true; // Reset for next tag
-    return OnHasLeftTag();
+    if (!is_self_closing_tag_)
+      return OnHasLeftTag();
+    else {
+      OnHasLeftTag();
+      is_self_closing_tag_ = false;
+      is_closing_tag_ = true;
+      return OnHasLeftTag();
+    }
   }
 
   if (ch == '"') {
@@ -484,7 +491,7 @@ bool Converter::OnHasLeftTag() {
   if (!is_closing_tag_) {
     tag->OnHasLeftOpeningTag(this);
   }
-  if (is_closing_tag_ || is_self_closing_tag_) {
+  else {
     is_closing_tag_ = false;
 
     tag->OnHasLeftClosingTag(this);

tests/main.cpp

@@ -352,6 +352,20 @@ bool testWhitespaceTags() {
   return true;
 }
 
+// Test self closing tags <a href=\"http://example1.com/\">First</a>  <br/> then <a href=\"http://example2.com\">second</a>
+bool testSelfClosingTags() {
+  testOption("selfClosingTags");
+
+  string html = "<a href=\"http://example1.com/\">First</a>  <br/> then <a href=\"http://example2.com\">second</a>";
+
+  html2md::Converter c(html);
+  auto md = c.convert();
+
+  return md.find("[First](http://example1.com/)") != string::npos &&
+         md.find("[second](http://example2.com)") != string::npos &&
+         md.find("  \n") != string::npos;
+}
+
 int main(int argc, const char **argv) {
   // List to store all markdown files in this dir
   vector<string> files;
@@ -409,7 +423,8 @@ int main(int argc, const char **argv) {
                 &testUppercaseAttributes,
                 &testMixedCaseTags,
                 &testSelfClosingUppercaseTags,
-                &testWhitespaceTags
+                &testWhitespaceTags,
+                &testSelfClosingTags,
               };
 
   for (const auto &test : tests)