fix writable derived waiting flag after refresh (#378)

Co-authored-by: Tim Smart <[email protected]>

Author: lucas-barake

.changeset/wicked-pianos-speak.md

@@ -0,0 +1,8 @@
+---
+"@effect-atom/atom": patch
+"@effect-atom/atom-livestore": patch
+"@effect-atom/atom-react": patch
+"@effect-atom/atom-vue": patch
+---
+
+establish atom relationship after rebuilds

packages/atom/src/internal/registry.ts

@@ -1,7 +1,7 @@
 import * as Effect from "effect/Effect"
 import * as Equal from "effect/Equal"
 import * as Exit from "effect/Exit"
-import { pipe } from "effect/Function"
+import { constVoid, pipe } from "effect/Function"
 import { globalValue } from "effect/GlobalValue"
 import * as Option from "effect/Option"
 import * as Queue from "effect/Queue"
@@ -11,7 +11,6 @@ import type * as Registry from "../Registry.js"
 import * as Result from "../Result.js"
 
 const constImmediate = { immediate: true }
-function constListener(_: any) {}
 
 /** @internal */
 export const TypeId: Registry.TypeId = "~effect-atom/atom/Registry"
@@ -116,7 +115,7 @@ class RegistryImpl implements Registry.Registry {
   }
 
   mount<A>(atom: Atom.Atom<A>) {
-    return this.subscribe(atom, constListener, constImmediate)
+    return this.subscribe(atom, constVoid, constImmediate)
   }
 
   atomHasTtl(atom: Atom.Atom<any>): boolean {
@@ -735,8 +734,9 @@ const makeLifetime = <A>(node: Node<A>): Lifetime<A> => {
       return node.registry.get(atom)
     }
     const parent = node.registry.ensureNode(atom)
+    const value = parent.value()
     node.addParent(parent)
-    return parent.value()
+    return value
   }
   Object.setPrototypeOf(get, LifetimeProto)
   get.isFn = false

packages/atom/test/Atom.test.ts

@@ -1388,6 +1388,40 @@ describe("Atom", () => {
     const result = r.get(atom)
     expect(Result.isInterrupted(result)).toBeTruthy()
   })
+
+  it("writable derived clears waiting after refresh", async () => {
+    let count = 0
+    const base = Atom.make(Effect.sync(() => ++count).pipe(Effect.delay(100))).pipe(
+      Atom.withLabel("base")
+    )
+    const derived = Atom.writable(
+      (get) => get(base),
+      () => {},
+      (refresh) => refresh(base)
+    ).pipe(
+      Atom.withLabel("derived")
+    )
+    const r = Registry.make()
+
+    const unmount1 = r.mount(derived)
+    await vitest.advanceTimersByTimeAsync(100)
+    let result = r.get(derived)
+    assert(Result.isSuccess(result))
+    expect(result.value).toEqual(1)
+    expect(result.waiting).toEqual(false)
+    unmount1()
+
+    r.refresh(derived)
+    const unmount2 = r.mount(derived)
+    await vitest.advanceTimersByTimeAsync(100)
+
+    result = r.get(derived)
+    expect(result.waiting).toEqual(false)
+    assert(Result.isSuccess(result))
+    expect(result.value).toEqual(2)
+
+    unmount2()
+  })
 })
 
 interface BuildCounter {