fix: add Scope.Scope support to AtomRuntime.subscriptionRef and subscribable (#380)

Co-authored-by: Tim Smart <[email protected]>

Author: mikearnaldi

.changeset/clever-turkeys-walk.md

@@ -0,0 +1,5 @@
+---
+"@effect-atom/atom": patch
+---
+
+add Scope support to Atom.subscriptionRef types

docs/atom/Atom.ts.md

@@ -1024,18 +1024,26 @@ export interface AtomRuntime<R, ER = never> extends Atom<Result.Result<Runtime.R
 
   readonly subscriptionRef: <A, E>(
     create:
-      | Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, R | AtomRegistry | Reactivity.Reactivity>
+      | Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, Scope.Scope | R | AtomRegistry | Reactivity.Reactivity>
       | ((
           get: Context
-        ) => Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, R | AtomRegistry | Reactivity.Reactivity>)
+        ) => Effect.Effect<
+          SubscriptionRef.SubscriptionRef<A>,
+          E,
+          Scope.Scope | R | AtomRegistry | Reactivity.Reactivity
+        >)
   ) => Writable<Result.Result<A, E>, A>
 
   readonly subscribable: <A, E, E1 = never>(
     create:
-      | Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, R | AtomRegistry | Reactivity.Reactivity>
+      | Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, Scope.Scope | R | AtomRegistry | Reactivity.Reactivity>
       | ((
           get: Context
-        ) => Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, R | AtomRegistry | Reactivity.Reactivity>)
+        ) => Effect.Effect<
+          Subscribable.Subscribable<A, E, R>,
+          E1,
+          Scope.Scope | R | AtomRegistry | Reactivity.Reactivity
+        >)
   ) => Atom<Result.Result<A, E | E1>>
 }
 ```

packages/atom/src/Atom.ts

@@ -622,18 +622,22 @@ export interface AtomRuntime<R, ER = never> extends Atom<Result.Result<Runtime.R
 
   readonly subscriptionRef: <A, E>(
     create:
-      | Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, R | AtomRegistry | Reactivity.Reactivity>
+      | Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, Scope.Scope | R | AtomRegistry | Reactivity.Reactivity>
       | ((
         get: Context
-      ) => Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, R | AtomRegistry | Reactivity.Reactivity>)
+      ) => Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, Scope.Scope | R | AtomRegistry | Reactivity.Reactivity>)
   ) => Writable<Result.Result<A, E>, A>
 
   readonly subscribable: <A, E, E1 = never>(
     create:
-      | Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, R | AtomRegistry | Reactivity.Reactivity>
+      | Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, Scope.Scope | R | AtomRegistry | Reactivity.Reactivity>
       | ((
         get: Context
-      ) => Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, R | AtomRegistry | Reactivity.Reactivity>)
+      ) => Effect.Effect<
+        Subscribable.Subscribable<A, E, R>,
+        E1,
+        Scope.Scope | R | AtomRegistry | Reactivity.Reactivity
+      >)
   ) => Atom<Result.Result<A, E | E1>>
 }
 

packages/atom/test/Atom.test.ts

@@ -979,6 +979,30 @@ describe("Atom", () => {
     unmount()
   })
 
+  it("SubscriptionRef/runtime/scoped", async () => {
+    let finalized = false
+    const atom = counterRuntime.subscriptionRef(
+      Effect.gen(function*() {
+        yield* Effect.addFinalizer(() =>
+          Effect.sync(() => {
+            finalized = true
+          })
+        )
+        return yield* SubscriptionRef.make(0)
+      })
+    )
+    const r = Registry.make()
+    const unmount = r.mount(atom)
+    assert.deepStrictEqual(r.get(atom), Result.success(0, { waiting: true }))
+    r.set(atom, 1)
+    await new Promise((resolve) => resolve(null))
+    assert.deepStrictEqual(r.get(atom), Result.success(1, { waiting: true }))
+    assert.strictEqual(finalized, false)
+    unmount()
+    await new Promise((resolve) => resolve(null))
+    assert.strictEqual(finalized, true)
+  })
+
   it("setLazy(true)", async () => {
     const count = Atom.make(0).pipe(Atom.keepAlive)
     let rebuilds = 0