Skip to content

Commit e2dec4f

Browse files
committed
Merge pull request pytest-dev#216 from blueyed/julen-issue/146
Test and fix for issue pytest-dev#146
2 parents b911f62 + 963e046 commit e2dec4f

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

pytest_django/lazy_django.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ def django_settings_is_configured():
2222

2323
# If DJANGO_SETTINGS_MODULE is defined at this point, Django is assumed to
2424
# always be loaded.
25-
from django.conf import settings
26-
assert settings.configured is True
2725
return True
2826

2927

tests/test_django_settings_module.py

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,25 @@ def test_ds_after_user_conftest(testdir, monkeypatch):
9696
result.stdout.fnmatch_lines(['*1 passed*'])
9797

9898

99+
def test_ds_in_pytest_configure(testdir, monkeypatch):
100+
monkeypatch.delenv('DJANGO_SETTINGS_MODULE')
101+
pkg = testdir.mkpydir('tpkg')
102+
settings = pkg.join('settings_ds.py')
103+
settings.write(BARE_SETTINGS)
104+
testdir.makeconftest("""
105+
import os
106+
107+
from django.conf import settings
108+
109+
def pytest_configure():
110+
if not settings.configured:
111+
os.environ.setdefault('DJANGO_SETTINGS_MODULE',
112+
'tpkg.settings_ds')
113+
""")
114+
r = testdir.runpytest()
115+
assert r.ret == 0
116+
117+
99118
def test_django_settings_configure(testdir, monkeypatch):
100119
"""
101120
Make sure Django can be configured without setting

0 commit comments

Comments
 (0)