Skip to content

Commit 68cee35

Browse files
author
Tim Sterne-Weiler
authored
Merge pull request #63 from timbitz/bfs-bugfix
Some default value updates for v0.10.2
2 parents 58e97c0 + 62af8fb commit 68cee35

File tree

5 files changed

+5
-15
lines changed

5 files changed

+5
-15
lines changed

bin/VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v0.10.1
1+
v0.10.2

bin/whippet-quant.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ function parse_cmd()
6767
"--score-min", "-S"
6868
help = "Minimum percent matching (matches - mismatches) / read_length"
6969
arg_type = Float64
70-
default = 0.6
70+
default = 0.7
7171
"--psi-body-read"
7272
help = "Allow exon-body reads in quantification of PSI values"
7373
action = :store_true

src/events.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,7 @@ end
644644

645645
function _process_spliced( sg::SpliceGraph, sgquant::SpliceGraphQuant,
646646
node::NodeInt, motif::EdgeMotif, bias::Float64, isnodeok::Bool,
647-
minedgeweight::Float64=0.025 )
647+
minedgeweight::Float64=0.02 )
648648

649649
inc_graph = Nullable{PsiGraph}()
650650
exc_graph = Nullable{PsiGraph}()

src/quant.jl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,12 @@ const SCALING_FACTOR = 1_000_000
66
# overridden for more complex count bias models
77
#const ReadCount = JointBiasCounter #DefaultCounter
88
const DEFAULT_DEF = (v = zero(DefaultCounter); v.isadjusted = true; v)
9-
#const DEFAULT_PRIME = (v = zero(PrimerBiasCounter); v.isadjusted = true; v)
10-
#const DEFAULT_GC = (v = zero(GCBiasCounter); v.isadjusted = true; v)
119
const DEFAULT_JOINT = (v = zero(JointBiasCounter); v.isadjusted = true; v)
1210

1311
const DEF_READCOUNT = 0.0
1412
const DEF_READVALUE = 1.0
1513

1614
default(::Type{DefaultCounter}) = DEFAULT_DEF
17-
#default(::Type{PrimerBiasCounter}) = DEFAULT_PRIME
18-
#default(::Type{GCBiasCounter}) = DEFAULT_GC
1915
default(::Type{JointBiasCounter}) = DEFAULT_JOINT
2016

2117
# Use this abstraction to store SGAlignPaths before

src/refset.jl

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ struct RefGene
1414
acc::CoordTuple
1515
txst::CoordTuple
1616
txen::CoordTuple
17-
# orfst::CoordTuple
18-
# orfen::CoordTuple
1917
exons::CoordTree
2018
length::Float64
2119
reftx::Vector{RefTx}
@@ -55,8 +53,6 @@ function load_refflat( fh; txbool=true )
5553
gnacc = Dict{GeneName,CoordTuple}()
5654
gntxst = Dict{GeneName,CoordTuple}()
5755
gntxen = Dict{GeneName,CoordTuple}()
58-
# gnorfst = Dict{GeneName,CoordTuple}()
59-
# gnorfen = Dict{GeneName,CoordTuple}()
6056
gnlens = Dict{GeneName,CoordTuple}()
6157
gnexons = Dict{GeneName,CoordTree}()
6258
gnreftx = Dict{GeneName,Vector{RefTx}}()
@@ -163,8 +159,6 @@ function load_gtf( fh; txbool=true, suppress=false )
163159
gnacc = Dict{GeneName,CoordTuple}()
164160
gntxst = Dict{GeneName,CoordTuple}()
165161
gntxen = Dict{GeneName,CoordTuple}()
166-
# gnorfst = Dict{GeneName,CoordTuple}()
167-
# gnorfen = Dict{GeneName,CoordTuple}()
168162
gnlens = Dict{GeneName,CoordTuple}()
169163
gnexons = Dict{GeneName,CoordTree}()
170164
gnreftx = Dict{GeneName,Vector{RefTx}}()
@@ -240,13 +234,13 @@ function load_gtf( fh; txbool=true, suppress=false )
240234
support,val = fetch_meta( "transcript_support_level", metaspl )
241235

242236
# if we observe low transcript support levels, we will warn the user
243-
if (support != "_" && support != "1" && support != "NA")
237+
if (support != "_" && support != "1" && support != "2" && support != "NA")
244238

245239
if suppress
246240
continue
247241
elseif !warning
248242
println(STDERR, "")
249-
warn("Using low quality Transcript Support Levels (TSL 2-5) in your GTF file is not recommended!\nFor more information on TSL, see: http://www.ensembl.org/Help/Glossary?id=492\n\nIf you would like Whippet to ignore these when building its index, use `--suppress-low-tsl` option!\n\n")
243+
warn("Using low quality Transcript Support Levels (TSL 3+) in your GTF file is not recommended!\nFor more information on TSL, see: http://www.ensembl.org/Help/Glossary?id=492\n\nIf you would like Whippet to ignore these when building its index, use `--suppress-low-tsl` option!\n\n")
250244

251245
warning=true
252246
end

0 commit comments

Comments
 (0)