Handle most lint warnings in the plugin. (flutter_lints 6.0.0)

Author: timbotimbo

lib/flutter_unity_widget.dart

@@ -1,4 +1,4 @@
-library flutter_unity_widget;
+library;
 
 export 'src/facade_controller.dart';
 export 'src/facade_widget.dart'

lib/src/facade_controller.dart

@@ -1,4 +1,4 @@
-typedef void UnityCreatedCallback(UnityWidgetController controller);
+typedef UnityCreatedCallback = void Function(UnityWidgetController controller);
 
 abstract class UnityWidgetController {
   static dynamic webRegistrar;

lib/src/facade_widget.dart

@@ -77,7 +77,7 @@ class UnityWidget extends StatefulWidget {
   final TextDirection? layoutDirection;
 
   @override
-  _UnityWidgetState createState() => _UnityWidgetState();
+  State<UnityWidget> createState() => _UnityWidgetState();
 }
 
 class _UnityWidgetState extends State<UnityWidget> {

lib/src/helpers/events.dart

@@ -5,32 +5,31 @@ class UnityEvent<T> {
   final int unityId;
 
   /// The value wrapped by this event
-  final T value;
+  final T? value;
 
   /// Build a Unity Event, that relates a mapId with a given value.
   ///
   /// The `unityId` is the id of the map that triggered the event.
   /// `value` may be `null` in events that don't transport any meaningful data.
-  UnityEvent(this.unityId, this.value);
+  UnityEvent(this.unityId, [this.value]);
 }
 
 class UnitySceneLoadedEvent extends UnityEvent<SceneLoaded?> {
-  UnitySceneLoadedEvent(int unityId, SceneLoaded? value)
-      : super(unityId, value);
+  UnitySceneLoadedEvent(super.unityId, super.value);
 }
 
 class UnityLoadedEvent extends UnityEvent<void> {
-  UnityLoadedEvent(int unityId, void value) : super(unityId, value);
+  UnityLoadedEvent(super.unityId);
 }
 
 class UnityUnLoadedEvent extends UnityEvent<void> {
-  UnityUnLoadedEvent(int unityId, void value) : super(unityId, value);
+  UnityUnLoadedEvent(super.unityId);
 }
 
 class UnityCreatedEvent extends UnityEvent<void> {
-  UnityCreatedEvent(int unityId, void value) : super(unityId, value);
+  UnityCreatedEvent(super.unityId);
 }
 
 class UnityMessageEvent extends UnityEvent<dynamic> {
-  UnityMessageEvent(int unityId, dynamic value) : super(unityId, value);
+  UnityMessageEvent(super.unityId, super.value);
 }

lib/src/helpers/misc.dart

@@ -12,6 +12,7 @@ class UnknownUnityIDError extends Error {
   /// Message describing the assertion error.
   final Object? message;
 
+  @override
   String toString() {
     if (message != null) {
       return "Unknown unity ID $unityId: ${Error.safeToString(message)}";
@@ -20,8 +21,8 @@ class UnknownUnityIDError extends Error {
   }
 }
 
-typedef void UnityMessageCallback(dynamic handler);
+typedef UnityMessageCallback = void Function(dynamic handler);
 
-typedef void UnitySceneChangeCallback(SceneLoaded? message);
+typedef UnitySceneChangeCallback = void Function(SceneLoaded? message);
 
-typedef void UnityUnloadCallback();
+typedef UnityUnloadCallback = void Function();

lib/src/io/device_method.dart

@@ -86,14 +86,14 @@ class MethodChannelUnityWidget extends UnityWidgetPlatform {
         _unityStreamController.add(UnityMessageEvent(unityId, call.arguments));
         break;
       case "events#onUnityUnloaded":
-        _unityStreamController.add(UnityLoadedEvent(unityId, call.arguments));
+        _unityStreamController.add(UnityLoadedEvent(unityId));
         break;
       case "events#onUnitySceneLoaded":
         _unityStreamController.add(UnitySceneLoadedEvent(
             unityId, SceneLoaded.fromMap(call.arguments)));
         break;
       case "events#onUnityCreated":
-        _unityStreamController.add(UnityCreatedEvent(unityId, call.arguments));
+        _unityStreamController.add(UnityCreatedEvent(unityId));
         break;
       default:
         throw UnimplementedError("Unimplemented ${call.method} method");
@@ -158,6 +158,7 @@ class MethodChannelUnityWidget extends UnityWidgetPlatform {
     bool? unityWebSource,
     String? unitySrcUrl,
   }) {
+    // ignore: no_leading_underscores_for_local_identifiers
     final String _viewType = 'plugin.xraph.com/unity_view';
 
     if (useAndroidViewSurf != null) useAndroidViewSurface = useAndroidViewSurf;

lib/src/io/mobile_unity_widget_controller.dart

@@ -70,6 +70,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
 
   /// Checks to see if unity player is ready to be used
   /// Returns `true` if unity player is ready.
+  @override
   Future<bool?>? isReady() {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.isReady(unityId: unityId);
@@ -79,6 +80,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
 
   /// Get the current pause state of the unity player
   /// Returns `true` if unity player is paused.
+  @override
   Future<bool?>? isPaused() {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.isPaused(unityId: unityId);
@@ -88,6 +90,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
 
   /// Get the current load state of the unity player
   /// Returns `true` if unity player is loaded.
+  @override
   Future<bool?>? isLoaded() {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.isLoaded(unityId: unityId);
@@ -97,6 +100,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
 
   /// Helper method to know if Unity has been put in background mode (WIP) unstable
   /// Returns `true` if unity player is in background.
+  @override
   Future<bool?>? inBackground() {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.inBackground(unityId: unityId);
@@ -107,6 +111,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
   /// Creates a unity player if it's not already created. Please only call this if unity is not ready,
   /// or is in unloaded state. Use [isLoaded] to check.
   /// Returns `true` if unity player was created succesfully.
+  @override
   Future<bool?>? create() {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.createUnityPlayer(unityId: unityId);
@@ -121,6 +126,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
   /// ```dart
   /// postMessage("GameManager", "openScene", "ThirdScene")
   /// ```
+  @override
   Future<void>? postMessage(String gameObject, methodName, message) {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.postMessage(
@@ -140,6 +146,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
   /// ```dart
   /// postJsonMessage("GameManager", "openScene", {"buildIndex": 3, "name": "ThirdScene"})
   /// ```
+  @override
   Future<void>? postJsonMessage(
       String gameObject, String methodName, Map<String, dynamic> message) {
     if (!_unityWidgetState.widget.enablePlaceholder) {
@@ -154,6 +161,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
   }
 
   /// Pause the unity in-game player with this method
+  @override
   Future<void>? pause() {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.pausePlayer(unityId: unityId);
@@ -162,6 +170,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
   }
 
   /// Resume the unity in-game player with this method idf it is in a paused state
+  @override
   Future<void>? resume() {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.resumePlayer(unityId: unityId);
@@ -171,6 +180,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
 
   /// Sometimes you want to open unity in it's own process and openInNativeProcess does just that.
   /// It works for Android and iOS is WIP
+  @override
   Future<void>? openInNativeProcess() {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.openInNativeProcess(unityId: unityId);
@@ -180,6 +190,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
 
   /// Unloads unity player from th current process (Works on Android only for now)
   /// iOS is WIP. For more information please read [Unity Docs](https://docs.unity3d.com/2020.2/Documentation/Manual/UnityasaLibrary.html)
+  @override
   Future<void>? unload() {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.unloadPlayer(unityId: unityId);
@@ -188,6 +199,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
   }
 
   /// Quits unity player. Note that this kills the current flutter process, thus quiting the app
+  @override
   Future<void>? quit() {
     if (!_unityWidgetState.widget.enablePlaceholder) {
       return UnityWidgetPlatform.instance.quitPlayer(unityId: unityId);
@@ -206,6 +218,7 @@ class MobileUnityWidgetController extends UnityWidgetController {
     _onUnityUnloadedSub = null;
   }
 
+  @override
   void dispose() {
     _cancelSubscriptions();
     UnityWidgetPlatform.instance.dispose(unityId: unityId);

lib/src/io/unity_widget.dart

@@ -126,7 +126,7 @@ class UnityWidget extends StatefulWidget {
   final TextDirection? layoutDirection;
 
   @override
-  _UnityWidgetState createState() => _UnityWidgetState();
+  State<UnityWidget> createState() => _UnityWidgetState();
 }
 
 class _UnityWidgetState extends State<UnityWidget> {

lib/src/io/windows_unity_widget_view.dart

@@ -1,7 +1,7 @@
 import 'package:flutter/material.dart';
 
 class WindowsUnityWidgetView extends StatefulWidget {
-  const WindowsUnityWidgetView({Key? key}) : super(key: key);
+  const WindowsUnityWidgetView({super.key});
 
   @override
   State<WindowsUnityWidgetView> createState() => _WindowsUnityWidgetViewState();

lib/src/web/unity_widget.dart

@@ -81,7 +81,7 @@ class UnityWidget extends StatefulWidget {
   final TextDirection? layoutDirection;
 
   @override
-  _UnityWidgetState createState() => _UnityWidgetState();
+  State<UnityWidget> createState() => _UnityWidgetState();
 }
 
 typedef WebUnityWidgetState = _UnityWidgetState;