in login!': undefined method split' for nil:NilClass (NoMethodError)

[AmmarKhawaja]

Hi, Im a bit new to Ruby and trying to use this API. Im getting this error:

in login!': undefined method split' for nil:NilClass (NoMethodError)

      cookie = response.headers['set-cookie'].split(' ').first
                                             ^^^^^^

My code is just the example code in the README:

require 'tesla_api'

tesla_api = TeslaApi::Client.new(email: "email", client_id: "id", client_secret: "secret")
tesla_api.login!('password123')
# Or if you have an access token:
#tesla_api = TeslaApi::Client.new(access_token: access_token) 

model_s = tesla_api.vehicles.first # => <TeslaApi::Vehicle>

model_s.wake_up
model_s.auto_conditioning_start unless model_s.climate_state["is_auto_conditioning_on"]

model_s.set_charge_limit(90)
model_s.charge_start

charge_state = model_s.charge_state
puts "Your Model S is #{charge_state["charging_state"]} " +
     "with a SOC of #{charge_state["battery_level"]}% " + 
     "and an estimate range of #{charge_state["est_battery_range"]} miles"

Any guidance would be helpful. Thank you

[dewski]

I am running into this as well with just the first 3 lines of the provided code above.

[duizendnegen]

Unfortunately, as described in https://tesla-api.timdorr.com/api-basics/authentication, the method of authentication you're using is deprecated. You can try to emulate the browser using Puppeteer for authentication, as detailed in #501 (comment).

[lemeo]

Hey @timdorr, I got the same issue. You already updated this ruby lib with the new SSO authentication way.

tesla-api/lib/tesla_api/client.rb

Lines 61 to 146 in 5e23c3b

	def login!(password, mfa_code: nil)
	code_verifier = rand(36**86).to_s(36)
	code_challenge = Base64.urlsafe_encode64(Digest::SHA256.hexdigest(code_verifier))
	state = rand(36**20).to_s(36)
	sso_api = Faraday.new(@sso_uri + "/oauth2/v3", ssl: {version: :TLSv1_2}) { |conn|
	# conn.response :logger, nil, {headers: true, bodies: true}
	conn.adapter Faraday.default_adapter
	}
	response = sso_api.get(
	"authorize",
	{
	client_id: "ownerapi",
	code_challenge: code_challenge,
	code_challenge_method: "S256",
	redirect_uri: "https://auth.tesla.com/void/callback",
	response_type: "code",
	scope: "openid email offline_access",
	state: state
	}
	)
	cookie = response.headers["set-cookie"].split(" ").first
	parameters = response.body.scan(/type="hidden" name="(.*?)" value="(.*?)"/).to_h
	transaction_id = parameters["transaction_id"]
	response = sso_api.post(
	"authorize?" + URI.encode_www_form({
	client_id: "ownerapi",
	code_challenge: code_challenge,
	code_challenge_method: "S256",
	redirect_uri: "https://auth.tesla.com/void/callback",
	response_type: "code",
	scope: "openid email offline_access",
	state: state
	}),
	URI.encode_www_form(parameters.merge(
	"identity" => email,
	"credential" => password
	)),
	"Cookie" => cookie
	)
	if response.body.match?(/passcode/)
	raise MFARequired if mfa_code.nil?
	raise MFAInvalidPasscode unless mfa_code.to_s.match?(/^\d{6}$/)
	factors = api.get(
	@sso_uri + "/oauth2/v3/authorize/mfa/factors",
	{
	transaction_id: transaction_id
	},
	"Cookie" => cookie
	).body
	response = @api.post(
	@sso_uri + "/oauth2/v3/authorize/mfa/verify",
	{
	factor_id: factors.dig("data", 0, "id"),
	passcode: mfa_code.to_s,
	transaction_id: transaction_id
	},
	"Cookie" => cookie
	).body
	raise MFAInvalidPasscode unless response.dig("data", "valid")
	response = sso_api.post(
	"authorize?" + URI.encode_www_form({
	client_id: "ownerapi",
	code_challenge: code_challenge,
	code_challenge_method: "S256",
	redirect_uri: "https://auth.tesla.com/void/callback",
	response_type: "code",
	scope: "openid email offline_access",
	state: state
	}),
	URI.encode_www_form({"transaction_id" => transaction_id}),
	"Cookie" => cookie
	)
	end
	code = CGI.parse(URI(response.headers["location"]).query)["code"].first
	exchange_oauth_code(code, code_verifier)
	end

Based on your update, from my understanding, the step to authenticate is as follows:
Step 1:

tesla_api = TeslaApi::Client.new(email: "tesla account email", client_id: nil, client_secret: nil)

We do not need to set client_id and client_secret since it is deprecated, and we have the default client_id set as ownerapi within login!(password) function.
Step 2:

tesla_api.login!('tesla account email')

Why do I get this error?

NoMethodError: undefined method `split' for nil:NilClass

Do we need to update the ruby lib? Or let me know the latest way to use this Ruby lib to authenticate. Thank you!