Avoid panicking on out-of-range value

Author: jhpratt

tests/time.rs

@@ -190,6 +190,13 @@ fn replace_millisecond() -> Result<()> {
     Ok(())
 }
 
+#[test]
+fn replace_millisecond_regression() {
+    assert!(Time::MIDNIGHT.replace_millisecond(9999).is_err());
+    assert!(Time::MIDNIGHT.replace_millisecond(4294).is_err());
+    assert!(Time::MIDNIGHT.replace_millisecond(4295).is_err());
+}
+
 #[test]
 fn replace_microsecond() -> Result<()> {
     assert_eq!(

time/src/lib.rs

@@ -284,8 +284,19 @@ macro_rules! ensure_ranged {
     };
 
     ($type:ident : $value:ident $(as $as_type:ident)? * $factor:expr) => {
-        match $type::new($value $(as $as_type)? * $factor) {
-            Some(val) => val,
+        match ($value $(as $as_type)?).checked_mul($factor) {
+            Some(val) => match $type::new(val) {
+                Some(val) => val,
+                None => {
+                    return Err(crate::error::ComponentRange {
+                        name: stringify!($value),
+                        minimum: $type::MIN.get() as i64 / $factor as i64,
+                        maximum: $type::MAX.get() as i64 / $factor as i64,
+                        value: $value as _,
+                        conditional_range: false,
+                    });
+                }
+            },
             None => {
                 return Err(crate::error::ComponentRange {
                     name: stringify!($value),