Stop copying loop var

This is no longer required since go1.22, see https://go.dev/blog/loopvar-preview

Author: timebertt

pkg/sharding/leases/shards.go

@@ -74,8 +74,7 @@ func (s Shards) IDs() []string {
 func ToShards(leases []coordinationv1.Lease, now time.Time) Shards {
 	shards := make(Shards, 0, len(leases))
 	for _, lease := range leases {
-		l := lease
-		shards = append(shards, ToShard(&l, now))
+		shards = append(shards, ToShard(&lease, now))
 	}
 	return shards
 }

webhosting-operator/cmd/experiment/main.go

@@ -153,9 +153,7 @@ func main() {
 	}
 	cmd.AddGroup(&group)
 
-	for _, s := range experiment.GetAllScenarios() {
-		scenario := s
-
+	for _, scenario := range experiment.GetAllScenarios() {
 		cmd.AddCommand(&cobra.Command{
 			Use:     scenario.Name(),
 			Short:   scenario.Description(),

webhosting-operator/pkg/metrics/theme.go

@@ -77,9 +77,7 @@ func (e *ThemeExporter) Collect(ch chan<- prometheus.Metric) {
 		return
 	}
 
-	for _, item := range themeList.Items {
-		theme := item
-
+	for _, theme := range themeList.Items {
 		staticLabels := generateThemeStaticLabels(&theme)
 
 		for _, desc := range themeMetrics {

webhosting-operator/pkg/metrics/website.go

@@ -78,9 +78,7 @@ func (e *WebsiteExporter) Collect(ch chan<- prometheus.Metric) {
 		return
 	}
 
-	for _, item := range websiteList.Items {
-		website := item
-
+	for _, website := range websiteList.Items {
 		staticLabels := generateWebsiteStaticLabels(&website)
 
 		for _, desc := range websiteMetrics {