Revert "Drop obsolete go collector in favor of controller-runtime" (#499)

This reverts commit ba4de9f.

Author: timebertt

cmd/sharder/app/app.go

@@ -21,6 +21,7 @@ import (
 	"fmt"
 
 	"github.com/go-logr/logr"
+	"github.com/prometheus/client_golang/prometheus/collectors"
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 	"go.uber.org/automaxprocs/maxprocs"
@@ -31,6 +32,7 @@ import (
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
+	"sigs.k8s.io/controller-runtime/pkg/metrics"
 
 	"github.com/timebertt/kubernetes-controller-sharding/pkg/controller"
 	healthzutils "github.com/timebertt/kubernetes-controller-sharding/pkg/utils/healthz"
@@ -90,6 +92,10 @@ func run(ctx context.Context, log logr.Logger, opts *options) error {
 		log.Error(err, "Failed to set GOMAXPROCS")
 	}
 
+	// replace deprecated legacy go collector
+	metrics.Registry.Unregister(collectors.NewGoCollector())
+	metrics.Registry.MustRegister(collectors.NewGoCollector(collectors.WithGoCollectorRuntimeMetrics(collectors.MetricsAll)))
+
 	log.Info("Setting up manager")
 	mgr, err := manager.New(opts.restConfig, opts.managerOptions)
 	if err != nil {

webhosting-operator/cmd/webhosting-operator/main.go

@@ -24,6 +24,7 @@ import (
 	goruntime "runtime"
 	"strconv"
 
+	"github.com/prometheus/client_golang/prometheus/collectors"
 	"go.uber.org/automaxprocs/maxprocs"
 	"go.uber.org/zap/zapcore"
 	appsv1 "k8s.io/api/apps/v1"
@@ -42,6 +43,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/healthz"
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
+	"sigs.k8s.io/controller-runtime/pkg/metrics"
 	"sigs.k8s.io/controller-runtime/pkg/metrics/filters"
 	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 
@@ -101,6 +103,10 @@ func main() {
 		setupLog.Error(err, "Failed to set GOMAXPROCS")
 	}
 
+	// replace deprecated legacy go collector
+	metrics.Registry.Unregister(collectors.NewGoCollector())
+	metrics.Registry.MustRegister(collectors.NewGoCollector(collectors.WithGoCollectorRuntimeMetrics(collectors.MetricsAll)))
+
 	mgr, err := ctrl.NewManager(opts.restConfig, opts.managerOptions)
 	if err != nil {
 		setupLog.Error(err, "unable to start manager")