Fix EachListItemWithAlloc and use it

Author: timebertt

pkg/controller/sharder/reconciler.go

@@ -166,7 +166,7 @@ func (r *Reconciler) resyncResource(
 
 	list := &metav1.PartialObjectMetadataList{}
 	list.SetGroupVersionKind(gvks[0])
-	err = pager.New(r.Reader).EachListItem(ctx, list,
+	err = pager.New(r.Reader).EachListItemWithAlloc(ctx, list,
 		func(obj client.Object) error {
 			if !namespaces.Has(obj.GetNamespace()) {
 				return nil

pkg/utils/pager/pager.go

@@ -68,7 +68,7 @@ type ListPager struct {
 // ListPager.PageBufferSize chunks buffered concurrently in the background.
 //
 // If items passed to fn are retained for different durations, and you want to avoid
-// retaining the whole slice returned by p.PageFn as long as any item is referenced,
+// retaining the whole slice returned by p.Reader.List as long as any item is referenced,
 // use EachListItemWithAlloc instead.
 func (p *ListPager) EachListItem(ctx context.Context, list client.ObjectList, fn func(obj client.Object) error, opts ...client.ListOption) error {
 	return p.eachListChunkBuffered(ctx, list, func(list client.ObjectList) error {
@@ -78,13 +78,13 @@ func (p *ListPager) EachListItem(ctx context.Context, list client.ObjectList, fn
 	}, opts...)
 }
 
-// EachListItemWithAlloc works like EachListItem, but avoids retaining references to the items slice returned by p.PageFn.
-// It does this by making a shallow copy of non-pointer items in the slice returned by p.PageFn.
+// EachListItemWithAlloc works like EachListItem, but avoids retaining references to the items slice returned by p.Reader.List.
+// It does this by making a shallow copy of non-pointer items in the slice returned by p.Reader.List.
 //
 // If the items passed to fn are not retained, or are retained for the same duration, use EachListItem instead for memory efficiency.
 func (p *ListPager) EachListItemWithAlloc(ctx context.Context, list client.ObjectList, fn func(obj client.Object) error, opts ...client.ListOption) error {
 	return p.eachListChunkBuffered(ctx, list, func(list client.ObjectList) error {
-		return meta.EachListItem(list, func(obj runtime.Object) error {
+		return meta.EachListItemWithAlloc(list, func(obj runtime.Object) error {
 			return fn(obj.(client.Object))
 		})
 	}, opts...)