Drop obsolete RecoverPanic=true

Author: timebertt

cmd/sharder/app/options.go

@@ -38,7 +38,6 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/cache"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/client/config"
-	controllerconfig "sigs.k8s.io/controller-runtime/pkg/config"
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
 	"sigs.k8s.io/controller-runtime/pkg/metrics/filters"
@@ -117,9 +116,6 @@ func (o *options) complete() error {
 		Scheme: scheme,
 		// allows us to quickly handover leadership on restarts
 		LeaderElectionReleaseOnCancel: true,
-		Controller: controllerconfig.Controller{
-			RecoverPanic: ptr.To(true),
-		},
 	}
 	o.applyConfigToManagerOptions()
 	o.applyCacheOptions()

pkg/webhook/sharder/add.go

@@ -52,7 +52,6 @@ func (h *Handler) AddToManager(mgr manager.Manager) error {
 	mgr.GetWebhookServer().Register(WebhookPathPrefix, &admission.Webhook{
 		Handler:         h,
 		WithContextFunc: NewContextWithRequestPath,
-		RecoverPanic:    true,
 	})
 	return nil
 }

webhosting-operator/cmd/experiment/main.go

@@ -31,9 +31,7 @@ import (
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 	clientgoscheme "k8s.io/client-go/kubernetes/scheme"
 	"k8s.io/klog/v2"
-	"k8s.io/utils/ptr"
 	ctrl "sigs.k8s.io/controller-runtime"
-	"sigs.k8s.io/controller-runtime/pkg/config"
 	"sigs.k8s.io/controller-runtime/pkg/healthz"
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
@@ -106,10 +104,6 @@ func main() {
 				},
 				// disable leader election
 				LeaderElection: false,
-
-				Controller: config.Controller{
-					RecoverPanic: ptr.To(true),
-				},
 			})
 			if err != nil {
 				return err

webhosting-operator/cmd/webhosting-operator/main.go

@@ -42,7 +42,6 @@ import (
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/cache"
 	"sigs.k8s.io/controller-runtime/pkg/client"
-	"sigs.k8s.io/controller-runtime/pkg/config"
 	"sigs.k8s.io/controller-runtime/pkg/healthz"
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 	"sigs.k8s.io/controller-runtime/pkg/metrics"
@@ -194,9 +193,6 @@ func (o *options) Complete() error {
 		Cache: cache.Options{
 			DefaultTransform: dropUnwantedMetadata,
 		},
-		Controller: config.Controller{
-			RecoverPanic: ptr.To(true),
-		},
 	}
 
 	o.applyConfigToRESTConfig()