Merge pull request #4 from timeplus-io/test-cxx-standard

disable sanitizer in custom command

Author: yuzifeng1984

CMakeLists_crosscompile.txt

@@ -20,9 +20,9 @@ include(CheckPythonModuleExists)
 
 check_python_module_exists(PYTHON_HAVE_MARKUPSAFE markupsafe)
 
-# Stick to std c++17 for some code (std::unique_ptr to fwd-decl type) can not be compiled under c++23 after llvm upgrade
+# Stick to std c++20 for some code (std::unique_ptr to fwd-decl type) can not be compiled under c++23 after llvm upgrade
 # if (NOT CMAKE_CXX_STANDARD)
-set(CMAKE_CXX_STANDARD 17)
+set(CMAKE_CXX_STANDARD 20)
 # endif()
 
 if (NOT CMAKE_C_STANDARD)
@@ -473,8 +473,10 @@ target_link_libraries(v8_snapshot
 )
 
 # Note: allow passing in v8_random_seed
+# proton: disable sanitizer
 add_custom_command(
   COMMAND
+    ASAN_OPTIONS=detect_container_overflow=0
     ${CMAKE_CURRENT_SOURCE_DIR}/mksnapshot
     --embedded_src ${CMAKE_CURRENT_BINARY_DIR}/embedded.S
     --startup_src ${CMAKE_CURRENT_BINARY_DIR}/snapshot.cc

CMakeLists_default.txt

@@ -20,9 +20,9 @@ include(CheckPythonModuleExists)
 
 check_python_module_exists(PYTHON_HAVE_MARKUPSAFE markupsafe)
 
-# Stick to std c++17 for some code (std::unique_ptr to fwd-decl type) can not be compiled under c++23 after llvm upgrade
+# Stick to std c++20 for some code (std::unique_ptr to fwd-decl type) can not be compiled under c++23 after llvm upgrade
 # if (NOT CMAKE_CXX_STANDARD)
-set(CMAKE_CXX_STANDARD 17)
+set(CMAKE_CXX_STANDARD 20)
 # endif()
 
 if (NOT CMAKE_C_STANDARD)
@@ -474,8 +474,10 @@ target_link_libraries(v8_snapshot
 
 # Note: allow passing in v8_random_seed
 # we use mksnapshot here
+# proton: disable sanitizer
 add_custom_command(
   COMMAND
+    ASAN_OPTIONS=detect_container_overflow=0
     ${CMAKE_CURRENT_BINARY_DIR}/mksnapshot
     --embedded_src ${CMAKE_CURRENT_BINARY_DIR}/embedded.S
     --startup_src ${CMAKE_CURRENT_BINARY_DIR}/snapshot.cc