Skip to content

Commit 89a57ea

Browse files
committed
Add cast to delete_by_id for safety/correctness
1 parent 91cc7ed commit 89a57ea

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

nbs/00_vector.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@
188188
" return \"TRUNCATE {table_name};\".format(table_name=self._quote_ident(self.table_name))\n",
189189
"\n",
190190
" def delete_by_ids_query(self, id: List[uuid.UUID]) -> Tuple[str, List]:\n",
191-
" query = \"DELETE FROM {table_name} WHERE id = ANY($1);\".format(table_name=self._quote_ident(self.table_name))\n",
191+
" query = \"DELETE FROM {table_name} WHERE id = ANY($1::uuid[]);\".format(table_name=self._quote_ident(self.table_name))\n",
192192
" return (query, [id])\n",
193193
"\n",
194194
" def delete_by_metadata_query (self, filter: Union[Dict[str, str], List[Dict[str, str]]]) -> Tuple[str, List]:\n",

timescale_vector/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def delete_all_query(self):
113113
return "TRUNCATE {table_name};".format(table_name=self._quote_ident(self.table_name))
114114

115115
def delete_by_ids_query(self, id: List[uuid.UUID]) -> Tuple[str, List]:
116-
query = "DELETE FROM {table_name} WHERE id = ANY($1);".format(table_name=self._quote_ident(self.table_name))
116+
query = "DELETE FROM {table_name} WHERE id = ANY($1::uuid[]);".format(table_name=self._quote_ident(self.table_name))
117117
return (query, [id])
118118

119119
def delete_by_metadata_query (self, filter: Union[Dict[str, str], List[Dict[str, str]]]) -> Tuple[str, List]:

0 commit comments

Comments
 (0)