Skip to content

Commit 61c32ca

Browse files
committed
Fix pg_lake install check for main/master versions
Update check_pg_lake to properly verify installation even for main/master branch builds. Previously, the function would skip checking for the .so file entirely for main/master versions, causing the final error check to fail when found=false. Now the check: 1. Verifies pg_lake.so exists for main/master versions 2. Records the version and sets found=true if installed 3. Logs (doesn't error) if not built for unsupported PG versions 4. Only errors for tagged versions that should exist but don't This allows the build to pass install checks when using PG_LAKE_VERSIONS=main.
1 parent 073057c commit 61c32ca

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

cicd/shared.sh

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,19 @@ check_pg_lake() {
197197
record_ext_version pg_lake "$pg" ""
198198

199199
for ver in $PG_LAKE_VERSIONS; do
200+
# For main/master branches, check if installed but don't verify specific version
200201
if [[ "$ver" = master || "$ver" = main ]]; then
201-
log "skipping looking for pg_lake-$ver"
202+
if [ -s "$lib/pg_lake.so" ]; then
203+
found=true
204+
record_ext_version pg_lake "$pg" "$ver"
205+
else
206+
unsupported_reason="$(supported_pg_lake "$pg" "$ver")"
207+
if [ -n "$unsupported_reason" ]; then
208+
log "skipped: pg_lake-$ver: $unsupported_reason"
209+
else
210+
log "pg_lake-$ver not built for pg$pg (skipping version check for main/master)"
211+
fi
212+
fi
202213
continue
203214
fi
204215

0 commit comments

Comments
 (0)