remove cloning of arbitrary waveform, and a todo

Author: alefminus

driver/src/lib.rs

@@ -205,7 +205,7 @@ pub trait PicoDriver: fmt::Debug + Send + Sync {
         _stop_delta_phase: u32,
         _delta_phase_increment: u32,
         _dwell_count: u32,
-        _arbitrary_waveform: &Vec<i16>,
+        _arbitrary_waveform: &mut Vec<i16>,
         _sweep_type: PicoSweepType,
         _operation: PicoExtraOperations,
         _index_mode: PicoIndexMode,

driver/src/ps2000a.rs

@@ -364,7 +364,7 @@ impl PicoDriver for PS2000ADriver {
         stop_delta_phase: u32,
         delta_phase_increment: u32,
         dwell_count: u32,
-        arbitrary_waveform: &Vec<i16>,
+        arbitrary_waveform: &mut Vec<i16>,
         sweep_type: PicoSweepType,
         operation: PicoExtraOperations,
         index_mode: PicoIndexMode,
@@ -373,11 +373,6 @@ impl PicoDriver for PS2000ADriver {
         trigger_source: PicoSigGenTrigSource,
         ext_in_threshold: i16,
     ) ->  PicoResult<()> {
-        // TODO: no idea how to do this better
-        // to avoid the data being taken away, store a copy here?
-        // go read the SDK to see if the memory is caller responsibility or
-        // copied by the library.
-        let mut arbitrary_waveform = arbitrary_waveform.clone();
         PicoStatus::from(unsafe {
             self.bindings.ps2000aSetSigGenArbitrary(
                 handle,

streaming/src/lib.rs

@@ -679,7 +679,7 @@ impl PicoStreamingDevice {
     #[tracing::instrument(skip(self), level = "trace")]
     pub fn set_sig_gen_arbitrary(
         &self,
-        props: SetSigGenArbitraryProperties,
+        mut props: SetSigGenArbitraryProperties,
     ) -> PicoResult<()> {
         // Start an AWG function
         let current_state = self.current_state.write();
@@ -730,7 +730,7 @@ impl PicoStreamingDevice {
             stop_delta_phase,
             delta_phase_increment,
             dwell_count,
-            &props.arbitrary_waveform,
+            &mut props.arbitrary_waveform,
             props.sweep_type,
             props.extra_operations,
             index_mode,