fix AsyncClient::connect memory leak me-no-dev#138

timhawes · timhawes · commit 1e3848feb745 · 2023-12-27T13:21:22.000Z
diff --git a/src/ESPAsyncTCP.cpp b/src/ESPAsyncTCP.cpp
@@ -266,6 +266,9 @@ bool AsyncClient::connect(IPAddress ip, uint16_t port){
   tcp_arg(pcb, this);
   tcp_err(pcb, &_s_error);
   size_t err = tcp_connect(pcb, &addr, port,(tcp_connected_fn)&_s_connected);
+  if (err != ERR_OK){
+    tcp_close(pcb);
+  }
   return (ERR_OK == err);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -266,6 +266,9 @@ bool AsyncClient::connect(IPAddress ip, uint16_t port){`
`266`	`266`	`tcp_arg(pcb, this);`
`267`	`267`	`tcp_err(pcb, &_s_error);`
`268`	`268`	`size_t err = tcp_connect(pcb, &addr, port,(tcp_connected_fn)&_s_connected);`
	`269`	`+ if (err != ERR_OK){`
	`270`	`+ tcp_close(pcb);`
	`271`	`+ }`
`269`	`272`	`return (ERR_OK == err);`
`270`	`273`	`}`
`271`	`274`