Merge pull request matplotlib#29966 from anntzer/outset-widget

Fix AxesWidgets on inset_axes that are outside their parent.

Author: greglucas

lib/matplotlib/tests/test_widgets.py

@@ -621,27 +621,36 @@ def test_rectangle_selector_ignore_outside(ax, ignore_event_outside):
     ('horizontal', False, dict(interactive=True)),
 ])
 def test_span_selector(ax, orientation, onmove_callback, kwargs):
-    onselect = mock.Mock(spec=noop, return_value=None)
-    onmove = mock.Mock(spec=noop, return_value=None)
-    if onmove_callback:
-        kwargs['onmove_callback'] = onmove
-
-    # While at it, also test that span selectors work in the presence of twin axes on
-    # top of the axes that contain the selector.  Note that we need to unforce the axes
-    # aspect here, otherwise the twin axes forces the original axes' limits (to respect
-    # aspect=1) which makes some of the values below go out of bounds.
+    # Also test that span selectors work in the presence of twin axes or for
+    # outside-inset axes on top of the axes that contain the selector.  Note
+    # that we need to unforce the axes aspect here, otherwise the twin axes
+    # forces the original axes' limits (to respect aspect=1) which makes some
+    # of the values below go out of bounds.
     ax.set_aspect("auto")
-    tax = ax.twinx()
-
-    tool = widgets.SpanSelector(ax, onselect, orientation, **kwargs)
-    MouseEvent._from_ax_coords("button_press_event", ax, (100, 100), 1)._process()
-    # move outside of axis
-    MouseEvent._from_ax_coords("motion_notify_event", ax, (199, 199), 1)._process()
-    MouseEvent._from_ax_coords("button_release_event", ax, (250, 250), 1)._process()
-
-    onselect.assert_called_once_with(100, 199)
-    if onmove_callback:
-        onmove.assert_called_once_with(100, 199)
+    ax.twinx()
+    child = ax.inset_axes([0, 1, 1, 1], xlim=(0, 200), ylim=(0, 200))
+
+    for target in [ax, child]:
+        selected = []
+        def onselect(*args): selected.append(args)
+        moved = []
+        def onmove(*args): moved.append(args)
+        if onmove_callback:
+            kwargs['onmove_callback'] = onmove
+
+        tool = widgets.SpanSelector(target, onselect, orientation, **kwargs)
+        MouseEvent._from_ax_coords(
+            "button_press_event", target, (100, 100), 1)._process()
+        # move outside of axis
+        MouseEvent._from_ax_coords(
+            "motion_notify_event", target, (199, 199), 1)._process()
+        MouseEvent._from_ax_coords(
+            "button_release_event", target, (250, 250), 1)._process()
+
+        # tol is set by pixel size (~100 pixels & span of 200 data units)
+        assert_allclose(selected, [(100, 199)], atol=.5)
+        if onmove_callback:
+            assert_allclose(moved, [(100, 199)], atol=.5)
 
 
 @pytest.mark.parametrize('interactive', [True, False])